Sirdata RTD Module : fix empty bidders param array bug & various optimizations #11367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
Apr 25, 2024
…mizations (prebid#11367) * fix empty params array bug & various optimizations * Update sirdataRtdProvider.js
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
…mizations (prebid#11367) * fix empty params array bug & various optimizations * Update sirdataRtdProvider.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
There was a bug relating to the module configuration parameters, when the publishers adds a filter for bidders and this filter is empty (empty array). We added a control on the length of the array which must be greater than 0, and optimized the code by removing parameters that had become obsolete.