Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXADS Bid Adapter : update bidder code before adapter is published #11464

Merged
merged 53 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
295e037
First commit
giuseppe-exads Jan 19, 2024
3dcb786
fix: readme.md
giuseppe-exads Jan 19, 2024
30eb51e
fix: changed exads urls
giuseppe-exads Jan 19, 2024
1e83db3
fix: Tools and suggestions related to the doc
giuseppe-exads Jan 19, 2024
38caa60
fix: from code review
giuseppe-exads Jan 22, 2024
bad299c
fix: from code review
giuseppe-exads Jan 22, 2024
0a4caf6
fix: from code review
giuseppe-exads Jan 22, 2024
9439670
fix: error from code review - native example
giuseppe-exads Jan 23, 2024
4965cfc
fox: from code review
giuseppe-exads Jan 24, 2024
091f340
fix: from code review
giuseppe-exads Jan 24, 2024
72163cf
fix: from code review
giuseppe-exads Jan 24, 2024
e0740ba
fix: native img set as mandatory
giuseppe-exads Jan 24, 2024
ec22581
fix: from code review
giuseppe-exads Jan 24, 2024
08b94c8
fix: from code review
giuseppe-exads Jan 24, 2024
fc03f90
fix: from code review
giuseppe-exads Jan 30, 2024
f4431a8
Merge branch 'master' into EX-16373
giuseppe-exads Jan 30, 2024
9b8ac1f
fix: from code review
giuseppe-exads Feb 20, 2024
d153e9a
fix: from code review
giuseppe-exads Feb 20, 2024
47bc992
fix: from code review
giuseppe-exads Feb 20, 2024
20edd7b
fix: bidfloor and bidfloorcur set as optional
giuseppe-exads Feb 20, 2024
a047b32
fix: dsa
giuseppe-exads Feb 20, 2024
17d705a
fix: mananing multiple responses
giuseppe-exads Feb 21, 2024
c2df4a1
fix: unit test after code review
giuseppe-exads Feb 21, 2024
f264a20
fix: fixing native snippet code
giuseppe-exads Feb 22, 2024
a89f377
fix: from code review
giuseppe-exads Feb 23, 2024
06b8349
fix: video events after code review
giuseppe-exads Feb 23, 2024
e3e8056
fix: video module into documentation
giuseppe-exads Feb 23, 2024
2cee2f3
fix: impression tracker for native
giuseppe-exads Feb 23, 2024
cbf78f7
fix: afeter code review
giuseppe-exads Feb 23, 2024
0c58be6
fix: unit tests
giuseppe-exads Feb 23, 2024
f807674
fix: added badv and bcat
giuseppe-exads Feb 26, 2024
85ad4f4
fix: video -> mimes and protocols
giuseppe-exads Feb 27, 2024
a5f14e4
fix
giuseppe-exads Feb 27, 2024
5029e42
fix: removed image_output and video_output params, forcing always htm…
giuseppe-exads Feb 27, 2024
d524e33
fix: gulp
giuseppe-exads Feb 28, 2024
12fc5bb
fix: added site.name
giuseppe-exads Mar 4, 2024
5cc107a
fix: removed EXADS dir
giuseppe-exads Mar 5, 2024
99098df
fix: after linting
giuseppe-exads Mar 5, 2024
a430eba
fix: unit tests
giuseppe-exads Mar 5, 2024
a27dec0
fix: final dsa solution
giuseppe-exads Mar 6, 2024
8666d36
Merge branch 'master' into EX-16373
giuseppe-exads Mar 6, 2024
9552cfe
fix: dsa
giuseppe-exads Mar 6, 2024
e38bfb7
fix: fix instream example
giuseppe-exads Mar 7, 2024
5a2ca31
fix: doc media type context
giuseppe-exads Mar 7, 2024
ad34d6b
fix: documented the endpoint param into native section
giuseppe-exads Mar 7, 2024
ab61372
Merge pull request #1 from EXADS/EX-16373
tfoliveira Mar 14, 2024
dc2a170
fix: related to markdown lint validation (#2)
giuseppe-exads Apr 4, 2024
06ee8d2
fix: from CR (#3)
giuseppe-exads Apr 11, 2024
6709a11
Merge branch 'prebid:master' into master
tfoliveira May 7, 2024
75c255e
fix: changed bidder code to exads
giuseppe-exads May 8, 2024
8c5cd03
fix: userAgent
giuseppe-exads May 8, 2024
9b74565
Merge pull request #4 from EXADS/EX-16373_CR_2
tfoliveira May 8, 2024
2f8a576
Merge branch 'master' into master
tfoliveira May 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions modules/exadsBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as utils from '../src/utils.js';
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
import { registerBidder } from '../src/adapters/bidderFactory.js';

const BIDDER = 'exadsadserver';
const BIDDER = 'exads';

const PARTNERS = {
ORTB_2_4: 'ortb_2_4'
Expand Down Expand Up @@ -332,12 +332,11 @@ function getEnvParams() {
envParams.osName = 'MacOS';
} else if (envParams.userAgent.match(/Unix/i)) {
envParams.osName = 'Unix';
// TODO: what is userAgent.userAgent supposed to be?
} else if (envParams.userAgent.userAgent?.match(/Android/i)) {
} else if (envParams.userAgent.match(/Android/i)) {
envParams.osName = 'Android';
} else if (envParams.userAgent.userAgent?.match(/iPhone|iPad|iPod/i)) {
} else if (envParams.userAgent.match(/iPhone|iPad|iPod/i)) {
envParams.osName = 'iOS';
} else if (envParams.userAgent.userAgent?.match(/Linux/i)) {
} else if (envParams.userAgent.match(/Linux/i)) {
envParams.osName = 'Linux';
} else {
envParams.osName = 'Unknown';
Expand Down
8 changes: 4 additions & 4 deletions modules/exadsBidAdapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ adUnits =
}
},
bids: [{
bidder: 'exadsadserver',
bidder: 'exads',
params: {
zoneId: 12345,
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
Expand Down Expand Up @@ -162,7 +162,7 @@ adUnits =
}
},
bids: [{
bidder: 'exadsadserver',
bidder: 'exads',
params: {
zoneId: 12345,
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
Expand Down Expand Up @@ -237,7 +237,7 @@ adUnits = [{
}
},
bids: [{
bidder: 'exadsadserver',
bidder: 'exads',
params: {
zoneId: 12345,
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
Expand Down Expand Up @@ -365,7 +365,7 @@ adUnits = [{
}
},
bids: [{
bidder: 'exadsadserver',
bidder: 'exads',
params: {
zoneId: 12345,
fid: '829a896f011475d50da0d82cfdd1af8d9cdb07ff',
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/exadsBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { spec, imps } from 'modules/exadsBidAdapter.js';
import { BANNER, NATIVE, VIDEO } from '../../../src/mediaTypes.js';

describe('exadsBidAdapterTest', function () {
const bidder = 'exadsadserver';
const bidder = 'exads';

const partners = {
ORTB_2_4: 'ortb_2_4'
Expand Down