Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invibes Bid Adapter : reading page referer and cookie handlid #11477

Merged
merged 6 commits into from
May 15, 2024
Merged

Invibes Bid Adapter : reading page referer and cookie handlid #11477

merged 6 commits into from
May 15, 2024

Conversation

rcheptanariu
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Updated bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Incremented internal bid version.
Removed a duplicated line.
Reading page referer.
Reading cookie handlid.

Other information

@ChrisHuie ChrisHuie requested a review from JulieLorin May 15, 2024 11:03
JulieLorin
JulieLorin approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@JulieLorin JulieLorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHuie ChrisHuie changed the title Invibes Bid Adapter : reading additional params Invibes Bid Adapter : reading page referer and cookie handlid May 15, 2024
@ChrisHuie ChrisHuie merged commit 5426945 into prebid:master May 15, 2024
4 checks passed
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request May 21, 2024
@rcheptanariu @mefjush
Invibes Bid Adapter : reading page referer and cookie handlid (prebid…
ae19329 
…#11477)

* InvibesBidAdapter - added cookie and referer read

* InvibesBidAdapter - unit tests

* InvibesBidAdapter - tab fix

* InvibesBidAdapter - null checks

* InvibesBidAdapter - fix { after if
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
@rcheptanariu @DecayConstant
Invibes Bid Adapter : reading page referer and cookie handlid (prebid…
ea057d1 
…#11477)

* InvibesBidAdapter - added cookie and referer read

* InvibesBidAdapter - unit tests

* InvibesBidAdapter - tab fix

* InvibesBidAdapter - null checks

* InvibesBidAdapter - fix { after if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulieLorin JulieLorin JulieLorin approved these changes

Assignees

@JulieLorin JulieLorin

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcheptanariu @JulieLorin @ChrisHuie