Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adagio Bid Adapter: preparation for new Rtd module and Prebid.js 9 #11485

Merged
merged 2 commits into from
May 21, 2024

Conversation

osazos
Copy link
Collaborator

@osazos osazos commented May 14, 2024

Type of change

  • Feature
  • Other

Description of change

Prepare the Adagio Bid Adapter to be ready for Prebid.js 9 (see #10038 and #10653)

As discussed in this thread, it will be followed by the submission of a new Adagio Rtd Provider.

More context:
We developed a new RTD Module that essentially mirrors the logic of our bidAdapter, minus the "cache" system that previously required us to use Function() and the encryption verification.

Rather than waiting for Prebid.js 9 to be released, we've made some slight modifications to our bidAdapter to ensure compatibility with the new RTD module and to streamline the transition for our clients. Primarily, this involves adding some if-else conditions to check for the presence of the RTD module.

Once the RTD module will be released, we will ask our clients to start using it and inform them that it will be mandatory in Prebid.js 9.
In parallel, we'll open a PR on the Prebid.js 9 branch to remove the legacy code.

@osazos osazos changed the title Adagio Bid Adapter: preparation for new Rtd module and Prebid.js com Adagio Bid Adapter: preparation for new Rtd module and Prebid.js May 14, 2024
@osazos osazos changed the title Adagio Bid Adapter: preparation for new Rtd module and Prebid.js Adagio Bid Adapter: preparation for new Rtd module and Prebid.js 9 May 14, 2024
@osazos osazos force-pushed the adagio-feature/prepare-for-rtd branch from 08b8b27 to 8b7ad87 Compare May 15, 2024 09:16
@ChrisHuie ChrisHuie requested a review from Rothalack May 15, 2024 11:14
@osazos osazos force-pushed the adagio-feature/prepare-for-rtd branch from 4e7fa0f to bc386d0 Compare May 15, 2024 12:25
Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working in testing for me.

@Rothalack Rothalack merged commit aa118c7 into prebid:master May 21, 2024
4 checks passed
@osazos osazos deleted the adagio-feature/prepare-for-rtd branch June 21, 2024 12:01
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
…rebid#11485)

* Utils: add isSafeFrameWindow(), canAccessWindowTop()

* AdagioBidAdapter: prepare to work with Adagio RTD Provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants