Adagio Bid Adapter: preparation for new Rtd module and Prebid.js 9 #11485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osazos
changed the title
osazos
changed the title
osazos
force-pushed
the
adagio-feature/prepare-for-rtd
branch
from
08b8b27 to
8b7ad87
Compare
osazos
force-pushed
the
adagio-feature/prepare-for-rtd
branch
from
4e7fa0f to
bc386d0
Compare
2 tasks
Rothalack
approved these changes
May 21, 2024
1 task
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
…rebid#11485) * Utils: add isSafeFrameWindow(), canAccessWindowTop() * AdagioBidAdapter: prepare to work with Adagio RTD Provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Prepare the Adagio Bid Adapter to be ready for Prebid.js 9 (see #10038 and #10653)
As discussed in this thread, it will be followed by the submission of a new Adagio Rtd Provider.
More context:
We developed a new RTD Module that essentially mirrors the logic of our bidAdapter, minus the "cache" system that previously required us to use
Function()and the encryption verification.Rather than waiting for Prebid.js 9 to be released, we've made some slight modifications to our bidAdapter to ensure compatibility with the new RTD module and to streamline the transition for our clients. Primarily, this involves adding some if-else conditions to check for the presence of the RTD module.
Once the RTD module will be released, we will ask our clients to start using it and inform them that it will be mandatory in Prebid.js 9.
In parallel, we'll open a PR on the Prebid.js 9 branch to remove the legacy code.