Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taboola Bid Adapter: fix ortb2 user override issue #11516

Merged
merged 3 commits into from
May 29, 2024

Conversation

ahmadlob
Copy link
Contributor

@ahmadlob ahmadlob commented May 19, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

user object entities in first party data (ortb2) not passed within the server generated request.
In this PR, fixed the override issue and passing what the ortb convertor generated "user" field as it is

Other information

Copy link
Contributor

@spotxslagle spotxslagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just like one small test added. Other than that, it LGTM

test/spec/modules/taboolaBidAdapter_spec.js Show resolved Hide resolved
@ahmadlob ahmadlob requested a review from spotxslagle May 21, 2024 21:36
@ahmadlob
Copy link
Contributor Author

@spotxslagle added more tests, thanks!

@ahmadlob
Copy link
Contributor Author

ahmadlob commented May 26, 2024

@ChrisHuie When approximately this PR will be merged? thanks
@spotxslagle

@ChrisHuie ChrisHuie merged commit 84e4359 into prebid:master May 29, 2024
4 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* pass-user-fields

* pass-user-fields

* tests added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants