optimera Rtd Module : hotfix for handling score file URIs #11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarbartopti
force-pushed
the
hotfix/optimera-score-uris
branch
from
b45a1c2 to
81c0585
Compare
|
This PR/module shouldn't have anything to do with User ID so I'm not sure what I should do about the CircleCI test which have failed. |
ChrisHuie
changed the title
ChrisHuie
approved these changes
May 21, 2024
|
@ChrisHuie Thanks for the code review and merge. When is the next Prebid.js release? |
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
There were some client scores which weren't being handled correctly due to a quirk with CF/S3's URI scheme
Other information
A minor problem for the most part, just needs handling.