Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/alias queue #1156

Merged
merged 10 commits into from
May 18, 2017
Merged

Improvement/alias queue #1156

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8f59e67
Replaced que with queue. Made the line terminator characters in pbjs_…
dbemiller Apr 25, 2017
b6d016f
Removed some redundant tests.
dbemiller Apr 25, 2017
8c593de
Separated que from queue, and added a deprecation warning. Wrote unit…
dbemiller Apr 26, 2017
6ed383b
Limited the number of deprecation warnings to at most 2.
dbemiller Apr 26, 2017
bdb7c2d
Style fixes.
dbemiller Apr 27, 2017
6e5ae12
Removed the deprecation warnings.
dbemiller May 5, 2017
ec53037
Merged from master. Resolved merge conflicts.
dbemiller May 5, 2017
65311e8
Merge branch 'master' of https://github.com/prebid/Prebid.js into imp…
dbemiller May 18, 2017
c90c6ef
Renamed queue to cmd, per the github poll.
dbemiller May 18, 2017
0da6aa6
Fixed two more occurrences of outdated strings/comments.
dbemiller May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions integrationExamples/gpt/gpt_aliasingBidder.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
if ($$PREBID_GLOBAL$$.initAdserverSet) return;

googletag.cmd.push(function () {
$$PREBID_GLOBAL$$.que.push(function () {
$$PREBID_GLOBAL$$.queue.push(function () {
$$PREBID_GLOBAL$$.setTargetingForGPTAsync();
googletag.pubads().refresh();
});
Expand All @@ -30,7 +30,7 @@
setTimeout(initAdserver, PREBID_TIMEOUT);

var $$PREBID_GLOBAL$$ = $$PREBID_GLOBAL$$ || {};
$$PREBID_GLOBAL$$.que = $$PREBID_GLOBAL$$.que || [];
$$PREBID_GLOBAL$$.queue = $$PREBID_GLOBAL$$.queue || [];

// Load the Prebid Javascript Library Async. We recommend loading it immediately after
// the initAdserver() and setTimeout functions.
Expand All @@ -54,7 +54,7 @@
node.parentNode.insertBefore(gads, node);
})();

$$PREBID_GLOBAL$$.que.push(function () {
$$PREBID_GLOBAL$$.queue.push(function () {
var adUnits = [
{
code: 'div-gpt-ad-12345678-0',
Expand Down Expand Up @@ -177,7 +177,7 @@ <h2>Prebid.js Test</h2>

ga('create', 'XXXXXX', 'auto');
//Send data from prebid.js automatically
$$PREBID_GLOBAL$$.que.push(function () {
$$PREBID_GLOBAL$$.queue.push(function () {
$$PREBID_GLOBAL$$.enableAnalytics({
provider: 'ga',
options: {
Expand Down
Loading