Ozone Bid Adapter: add support for GPP Module & updates #11648
Conversation
|
Hi @patmmccann - I've tried to resubmit my PR a couple of times - the error looks to be with the circle CI tests as opposed to the code submitted - I think I can see other PRs also with a similar issue/error preventing the checks from successfully passing. |
ChrisHuie
changed the title
|
@AskRupert-DM looks like none of the tests ran ```Chrome 125.0.0.0 (Windows 10): Executed 0 of 0 SUCCESS (0 secs / 0 secs) |
|
Thanks can see the checks have run - will review your comments and push some updates accordingly/feedback once I've reviewed @patmmccann |
|
think majority of your feedback has been addressed/handled in the latest submission which also seems to have passed testing - hopefully good to go now @patmmccann - lmk your thoughts when you get a minute! |
|
hey @patmmccann have responded to the outstanding comments - the adapter passed our internal QA and all the automated tests here. The remainder feedback you had provided did not require any actions from me. There was a comment that we have removed in our latest submission and the feedback around pclmt I don't think requires any changes from me. If this is defined on page - prebid core adds the array object to the bid-request unless you are saying that's not the case ? |
|
@AskRupert-DM looks good, please resolve the conflict |
modules/ozoneBidAdapter.js
Outdated
| this.tryGetPubCidFromOldLocation(ret, bidRequest); // legacy | ||
| return ret; | ||
| } | ||
| let keymap = { |
There was a problem hiding this comment.
this is a very large block of code to add. Is it adding value to the publisher?
AskRupert-DM
force-pushed
the
ozone-2.9.2
branch
from
34d1de8 to
03d4162
Compare
fix to address plcmt feedback
|
@patmmccann have updated - hopefully we can get this merged into the next release! |
|
Thanks! Merged in |
* Update ozoneBidAdapter.js * Update ozoneBidAdapter_spec.js * Update ozoneBidAdapter_spec.js * Update ozoneBidAdapter.js fix to address plcmt feedback
Type of change
Bugfix
Feature
New bidder adapter
[x ] Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information