-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZetaGlobalSsp adapter: merge ortb2.site and params.site #11773
ZetaGlobalSsp adapter: merge ortb2.site and params.site #11773
Conversation
Pull master
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
Looks to be failing tests and requiring several code block imports to solve duplication with zmaticoo |
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
@patmmccann thanks for review. That issue has been fixed |
Doesn't look fixed, this adapter and zmatico should have a bunch of common imports committed |
@patmmccann still didn't understand the issue here. Should I change not our zmaticoo Adapter? How to know what exactly lines should I move to common methods? To where? Do you have any example of this? First time saw the issue like this |
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
This reverts commit a075583.
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀 |
@patmmccann |
Are you not affiliated with zmatico? Have you seen the example in #11854 in which 20+ roughly identical adapters moved their functions into a library? |
Your comments are quite reasonable, we're thinking about what to do still |
One option, your adapter simply needs many updates: almost everything you take in a param needs the treatment of this pr, including the user object especially. Your usersync and constants block can reasonably be moved to /libraries/zetaUtils and we can fix zmaticoo to import them. Also I think this pr makes some of your site and device handling logic redundant or never reached, eg navigator.useragent |
* ZetaGlobalSsp adapter: merge params.site and ortb2.site * fix unit test * extract buildVideo into utils * Revert "extract buildVideo into utils" This reverts commit a075583. --------- Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com> Co-authored-by: Alexey Surovenko <ASurovenko@vdhk6ddf9m.home>
Type of change
Merge params.site and ortb2.site in payload.site