PBjs Core : expire stale bids directly from auction object to prevent long TTL bid #11776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds from exploding memory
dgirardi
reviewed
Jun 12, 2024
| entries: () => auctionManager.getNoBids() | ||
| } | ||
| }).forEach(([t, {bd, entries}]) => { | ||
| it(`with ${t} are never dropped if minBidCacheTTL is not set`, () => { |
There was a problem hiding this comment.
would it be better to keep this behavior? expire individual bids the same way auctions are, after Math.max(bid.ttl, getConfig('minBidCacheTTL')), and only if minBidCacheTTL is set. This way pubs can choose whether they want this / they don't have to reason about two different expiration mechanisms.
There was a problem hiding this comment.
@fowler446 are you still working on this? Can you provide your perspective on this?
ChrisHuie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
By expiring bids after their TTL has elapsed directly in the auction object we prevent bids with long TTLs from hogging memory. At the moment when there is a long TTL bid in an auction, all the other bids are kept long after their expiry.
Relevant Issue
#11310