Smaato Bid Adapter : add DOOH support #11801
Conversation
| request.site.content = content; | ||
| } | ||
| setPublisherId(request.site); | ||
| } else if (request.dooh) { |
There was a problem hiding this comment.
This feels very fragile; I would reverse the conditional and always send a dooh request if a dooh object exists, instead of putting it in the else.
There was a problem hiding this comment.
But there should be only one of app, site or dooh present in a request as per ortb specification
There was a problem hiding this comment.
Right, I am saying, right now you will always choose site if both site and dooh exist. Do you prefer to always choose DOOH in that scenario and jettison the site object?
There was a problem hiding this comment.
We generally prefer site over dooh
I thought (might be confusing with prebid-server tho) that there's an internal check that prevents this kind of misconfiguration before it reaches the adapter code?
There was a problem hiding this comment.
Okay, I don't think there's any such check, but there might be one I'm unaware of
ChrisHuie
changed the title
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Adding DOOH support for Smaato adapter
Other information