Prebid Core: TTL counts only when page is active #11803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
isn't the bid TTL an hard cut off, from delivery? e.g. we've seen SSP's rejecting bids if the bid get's executed after delivery time + TTL expired. taking only focus time could attribute to executing the bid after it's ttl? |
|
@olafbuitelaar this doesn't change the effect TTL has on which bids are picked, it's to fix an edge case (#11268) where:
in theory it shouldn't matter since the bid expired, but many bidders don't really have TTLs (a lot just hardcode some random number) or don't enforce it. |
mkomorski
force-pushed
the
11268-deferred-timeout-master
branch
from
b485987
to
ccf7b14
Compare
dgirardi
reviewed
Jun 19, 2024
src/utils/focusTimeout.js
Outdated
| setFocusTimeout(callback, timeOutOfFocus - startTime); | ||
| } | ||
| }, milliseconds); | ||
| return timerId; |
There was a problem hiding this comment.
the false return value came back!
mkomorski
force-pushed
the
11268-deferred-timeout-master
branch
from
6b12f54
to
5302580
Compare
dgirardi
approved these changes
Jun 21, 2024
patmmccann
approved these changes
Jun 23, 2024
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
* 11268 TTL counts only when page is active * refactor * refactor due to performance optimization * get rid of false timer id --------- Co-authored-by: Marcin Komorski <marcinkomorski@Marcins-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
#11268