Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loyal Bid Adapter : no error without floors module #11834

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

patmmccann
Copy link
Collaborator

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@ChrisHuie ChrisHuie changed the title LoyalBidAdapter.js: no error without floors module Loyal Bid Adapter : no error without floors module Jun 20, 2024
@ChrisHuie ChrisHuie merged commit 1a8b993 into master Jun 20, 2024
4 of 5 checks passed
@ChrisHuie ChrisHuie deleted the patmmccann-patch-14 branch June 20, 2024 11:10
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
* LoyalBidAdapter.js: no error without floors module

* Update loyalBidAdapter.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants