Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dailymotion Bid Adapter : fix user sync parsing #11887

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Dailymotion Bid Adapter : fix user sync parsing #11887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea76d35
Dailymotion bid adapter: Fix user sync parsing
Mar 5, 2024
ae9fac1
Merge pull request #30 from dailymotion-oss/dailymotion_fix_usersyncs
sebmil-daily Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/dailymotionBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export const spec = {
const pixelSyncs = [];

serverResponses.forEach((response) => {
(response.user_syncs || []).forEach((syncUrl) => {
(response?.body?.userSyncs || []).forEach((syncUrl) => {
if (syncUrl.type === 'image') {
pixelSyncs.push({ url: syncUrl.url, type: 'image' });
}
Expand Down
32 changes: 18 additions & 14 deletions test/spec/modules/dailymotionBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ describe('dailymotionBidAdapterTests', () => {

// No permissions
{
const responses = [{ user_syncs: [{ url: 'https://usersyncurl.com', type: 'image' }] }];
const responses = [{ body: { userSyncs: [{ url: 'https://usersyncurl.com', type: 'image' }] } }];
const syncOptions = { iframeEnabled: false, pixelEnabled: false };

expect(config.runWithBidder(
Expand All @@ -656,7 +656,7 @@ describe('dailymotionBidAdapterTests', () => {
)).to.eql([]);
}

// Has permissions but no user_syncs urls
// Has permissions but no userSyncs urls
{
const responses = [{}];
const syncOptions = { iframeEnabled: false, pixelEnabled: true };
Expand All @@ -667,14 +667,16 @@ describe('dailymotionBidAdapterTests', () => {
)).to.eql([]);
}

// Return user_syncs urls for pixels
// Return userSyncs urls for pixels
{
const responses = [{
user_syncs: [
{ url: 'https://usersyncurl.com', type: 'image' },
{ url: 'https://usersyncurl2.com', type: 'image' },
{ url: 'https://usersyncurl3.com', type: 'iframe' }
],
body: {
userSyncs: [
{ url: 'https://usersyncurl.com', type: 'image' },
{ url: 'https://usersyncurl2.com', type: 'image' },
{ url: 'https://usersyncurl3.com', type: 'iframe' }
],
}
}];

const syncOptions = { iframeEnabled: false, pixelEnabled: true };
Expand All @@ -688,14 +690,16 @@ describe('dailymotionBidAdapterTests', () => {
]);
}

// Return user_syncs urls for iframes
// Return userSyncs urls for iframes
{
const responses = [{
user_syncs: [
{ url: 'https://usersyncurl.com', type: 'image' },
{ url: 'https://usersyncurl2.com', type: 'image' },
{ url: 'https://usersyncurl3.com', type: 'iframe' }
],
body: {
userSyncs: [
{ url: 'https://usersyncurl.com', type: 'image' },
{ url: 'https://usersyncurl2.com', type: 'image' },
{ url: 'https://usersyncurl3.com', type: 'iframe' }
],
}
}];

const syncOptions = { iframeEnabled: true, pixelEnabled: true };
Expand Down