Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DapRtdProvider: - renaming module from Akamai* to Symitri* and updating all Header and code references #11893

Closed

Conversation

jpalladino84
Copy link
Contributor

@jpalladino84 jpalladino84 commented Jul 1, 2024

Type of change

  • Updated bidder adapter

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

  • Changing ownership of the Akamai DapRtdProvider to Symitri
  • Renaming core module
  • Updating module code with updated references to Symitri instead of Akamai
  • Updating module tests with new references
  • Updating accompanying comments and documentation

Other information

prebid/prebid.github.io#5469

Copy link

github-actions bot commented Jul 1, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@patmmccann
Copy link
Collaborator

patmmccann commented Jul 1, 2024

Please follow this pattern to import the new module from the old filename so you do not break any build scripts. In
future major release you may delete the old module. https://github.com/prebid/Prebid.js/pull/10176/files#diff-2b879051268bc9adc282e53129f325e4c1d148dc206370695c7c7b1881682c89

Please also take care of the self-duplication flagged by using functions ( do not rename variables or reorder objects :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants