Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core (secureCreatives) : Report resize warning as error #11896

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Sir-Will
Copy link
Contributor

@Sir-Will Sir-Will commented Jul 1, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

When Prebid is unable to find the element to resize, it only logs it as a warning, while it results in a broken rendered ad. This changes it to be logged as error, to be more noticeable.

Other information

This can cause too big of an issue for reporting it only as warning.
@patmmccann patmmccann self-assigned this Jul 1, 2024
@patmmccann patmmccann self-requested a review July 1, 2024 17:44
@patmmccann patmmccann changed the title Report resize warning as error Core: Report resize warning as error Jul 1, 2024
@ChrisHuie ChrisHuie changed the title Core: Report resize warning as error Core (SecureCreative) : Report resize warning as error Jul 2, 2024
@ChrisHuie ChrisHuie changed the title Core (SecureCreative) : Report resize warning as error Core (secureCreatives) : Report resize warning as error Jul 2, 2024
@ChrisHuie ChrisHuie merged commit ecd9a7b into prebid:master Jul 2, 2024
5 checks passed
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this pull request Jul 18, 2024
This can cause too big of an issue for reporting it only as warning.
mefjush pushed a commit to adhese/Prebid.js that referenced this pull request Jul 19, 2024
This can cause too big of an issue for reporting it only as warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants