Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdmixerBidAdapter: rtbstack change endpointId to tagId #11925

Merged
merged 9 commits into from
Jul 5, 2024
Merged

AdmixerBidAdapter: rtbstack change endpointId to tagId #11925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5258b05
Update README.md
AdmixerTech May 1, 2023
15bc431
Merge remote-tracking branch 'Prebid.js/master'
AdmixerTech May 10, 2023
97974c1
Merge branch 'master-2'
AdmixerTech May 29, 2023
dd47d95
Merge branch 'prebid:master' into master
AdmixerTech Dec 19, 2023
0666d05
Add admixerwl alias for admixerBidAdapter.
Dec 19, 2023
1a524ae
Merge remote-tracking branch 'upstream/master'
dariaboyko Feb 22, 2024
b62e6c0
Merge branch 'prebid:master' into master
dariaboyko Jul 2, 2024
d492c78
Merge branch 'prebid:master' into master
dariaboyko Jul 4, 2024
1c22488
admixer change endpointId to tagId
Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/admixerBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const spec = {
*/
isBidRequestValid: function (bid) {
return bid.bidder === 'rtbstack'
? !!bid.params.endpointId
? !!bid.params.tagId
: !!bid.params.zone;
},
/**
Expand Down
6 changes: 3 additions & 3 deletions modules/admixerBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Please use ```admixer``` as the bidder code.
{
bidder: "rtbstack",
params: {
endpointId: 41512
tagId: 41512
}
}
]
Expand All @@ -72,7 +72,7 @@ Please use ```admixer``` as the bidder code.
{
bidder: "rtbstack",
params: {
endpointId: 41512
tagId: 41512
}
}
]
Expand All @@ -84,7 +84,7 @@ Please use ```admixer``` as the bidder code.
{
bidder: "rtbstack",
params: {
endpointId: 41512
tagId: 41512
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/admixerBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('AdmixerAdapter', function () {
let rtbBid = {
bidder: RTB_BIDDER_CODE,
params: {
endpointId: ENDPOINT_ID,
tagId: ENDPOINT_ID,
},
adUnitCode: 'adunit-code',
sizes: [
Expand Down Expand Up @@ -133,7 +133,7 @@ describe('AdmixerAdapter', function () {
{
bidder: bidder,
params: bidder === 'rtbstack' ? {
endpointId: ENDPOINT_ID
tagId: ENDPOINT_ID
} : {
zone: ZONE_ID,
},
Expand Down