Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttd bid adapter: configurable endpoint #12004

Merged
merged 8 commits into from
Jul 26, 2024
Merged

ttd bid adapter: configurable endpoint #12004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8d24055
support endpoint params for ttd adapter
Jul 19, 2024
63fb2bb
update to support http2 endpoint only
Jul 22, 2024
fa993b8
remove dup code
Jul 22, 2024
f04af4a
add missing file
Jul 22, 2024
c6dd324
fix battr issue
Jul 22, 2024
495134c
fix warning
Jul 22, 2024
12e77de
update connection type
Jul 23, 2024
b7466eb
add 5g
Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions libraries/connectionInfo/connectionUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/**
* Returns the type of connection.
*
* @returns {number} - Type of connection.
*/
export function getConnectionType() {
const connection = navigator.connection || navigator.webkitConnection;
if (!connection) {
return 0;
}
switch (connection.type) {
case 'ethernet':
return 1;
case 'wifi':
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to include "wimax" with this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added. And checked for chrome/edge looks like connection.type is not always there but connection.effectiveType has value. Updated to handle that case.

return 2;
case 'wimax':
return 6;
default:
switch (connection.effectiveType) {
case 'slow-2g':
case '2g':
return 4;
case '3g':
return 5;
case '4g':
return 6;
case '5g':
return 7;
default:
return connection.type == 'cellular' ? 3 : 0;
}
}
}
28 changes: 1 addition & 27 deletions modules/prismaBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {config} from '../src/config.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';
import {getANKeywordParam} from '../libraries/appnexusUtils/anKeywords.js';
import {getConnectionType} from '../libraries/connectionInfo/connectionUtils.js'

/**
* @typedef {import('../src/adapters/bidderFactory.js').BidRequest} BidRequest
Expand All @@ -20,33 +21,6 @@ const METRICS_TRACKER_URL = 'https://prisma.nexx360.io/track-imp';

const GVLID = 965;

function getConnectionType() {
const connection = navigator.connection || navigator.webkitConnection;
if (!connection) {
return 0;
}
switch (connection.type) {
case 'ethernet':
return 1;
case 'wifi':
return 2;
case 'cellular':
switch (connection.effectiveType) {
case 'slow-2g':
case '2g':
return 4;
case '3g':
return 5;
case '4g':
return 6;
default:
return 3;
}
default:
return 0;
}
}

export const spec = {
code: BIDDER_CODE,
gvlid: GVLID,
Expand Down
46 changes: 14 additions & 32 deletions modules/ttdBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import * as utils from '../src/utils.js';
import { config } from '../src/config.js';
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, VIDEO } from '../src/mediaTypes.js';
import {isNumber} from '../src/utils.js';
import { isNumber } from '../src/utils.js';
import { getConnectionType } from '../libraries/connectionInfo/connectionUtils.js'

/**
* @typedef {import('../src/adapters/bidderFactory.js').BidRequest} BidRequest
Expand All @@ -13,10 +14,11 @@ import {isNumber} from '../src/utils.js';
* @typedef {import('../src/adapters/bidderFactory.js').UserSync} UserSync
*/

const BIDADAPTERVERSION = 'TTD-PREBID-2023.09.05';
const BIDADAPTERVERSION = 'TTD-PREBID-2024.07.26';
const BIDDER_CODE = 'ttd';
const BIDDER_CODE_LONG = 'thetradedesk';
const BIDDER_ENDPOINT = 'https://direct.adsrvr.org/bid/bidder/';
const BIDDER_ENDPOINT_HTTP2 = 'https://d2.adsrvr.org/bid/bidder/';
const USER_SYNC_ENDPOINT = 'https://match.adsrvr.org';

const MEDIA_TYPE = {
Expand Down Expand Up @@ -99,33 +101,6 @@ function getDevice(firstPartyData) {
return device;
};

function getConnectionType() {
const connection = navigator.connection || navigator.webkitConnection;
if (!connection) {
return 0;
}
switch (connection.type) {
case 'ethernet':
return 1;
case 'wifi':
return 2;
case 'cellular':
switch (connection.effectiveType) {
case 'slow-2g':
case '2g':
return 4;
case '3g':
return 5;
case '4g':
return 6;
default:
return 3;
}
default:
return 0;
}
}

function getUser(bidderRequest, firstPartyData) {
let user = {};
if (bidderRequest.gdprConsent) {
Expand Down Expand Up @@ -241,7 +216,7 @@ function banner(bid) {
},
optionalParams);

const battr = utils.deepAccess(bid, 'ortb2Imp.battr');
const battr = utils.deepAccess(bid, 'ortb2Imp.banner.battr');
if (battr) {
banner.battr = battr;
}
Expand Down Expand Up @@ -318,7 +293,7 @@ function video(bid) {
video.maxbitrate = maxbitrate;
}

const battr = utils.deepAccess(bid, 'ortb2Imp.battr');
const battr = utils.deepAccess(bid, 'ortb2Imp.video.battr');
if (battr) {
video.battr = battr;
}
Expand All @@ -327,6 +302,13 @@ function video(bid) {
}
}

function selectEndpoint(params) {
if (params.useHttp2) {
return BIDDER_ENDPOINT_HTTP2;
}
return BIDDER_ENDPOINT;
}

export const spec = {
code: BIDDER_CODE,
gvlid: 21,
Expand Down Expand Up @@ -443,7 +425,7 @@ export const spec = {
topLevel.pmp = firstPartyData.pmp
}

let url = BIDDER_ENDPOINT + bidderRequest.bids[0].params.supplySourceId;
let url = selectEndpoint(bidderRequest.bids[0].params) + bidderRequest.bids[0].params.supplySourceId;

let serverRequest = {
method: 'POST',
Expand Down
11 changes: 10 additions & 1 deletion test/spec/modules/ttdBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,13 @@ describe('ttdBidAdapter', function () {
expect(url).to.equal('https://direct.adsrvr.org/bid/bidder/supplier');
});

it('sends bid requests to the correct custom endpoint', function () {
let bannerBidRequestsWithCustomEndpoint = deepClone(baseBannerBidRequests);
bannerBidRequestsWithCustomEndpoint[0].params.useHttp2 = true;
const url = testBuildRequests(bannerBidRequestsWithCustomEndpoint, baseBidderRequest).url;
expect(url).to.equal('https://d2.adsrvr.org/bid/bidder/supplier');
});

it('sends publisher id', function () {
const requestBody = testBuildRequests(baseBannerBidRequests, baseBidderRequest).data;
expect(requestBody.site).to.be.not.null;
Expand Down Expand Up @@ -442,7 +449,9 @@ describe('ttdBidAdapter', function () {
let clonedBannerRequests = deepClone(baseBannerBidRequests);
const battr = [1, 2, 3];
clonedBannerRequests[0].ortb2Imp = {
battr: battr
banner: {
battr: battr
}
};
const requestBody = testBuildRequests(clonedBannerRequests, baseBidderRequest).data;
expect(requestBody.imp[0].banner.battr).to.equal(battr);
Expand Down
Loading