AdPlayerPro Video Module : initial module release #12150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
ChrisHuie
changed the title
karimMourra
reviewed
Sep 10, 2024
Comment on lines
+117
to
+118
| function getOrtbContent() { | ||
| } |
There was a problem hiding this comment.
If the player has content information such as media source url , media id, media title etc, it would be good to populate. Contextual targeting can help get higher bids
There was a problem hiding this comment.
This module only supports outstream format, so it does not use content.
karimMourra
requested changes
Sep 10, 2024
|
@artemAdp can you please add documentation for this new module in our docs repo https://github.com/prebid/prebid.github.io |
2 tasks
|
@ChrisHuie Thank you for your comment. I have added documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New video module for AdPlayer.Pro
Other information