Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price floors module : accept null floors #12295

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Price floors module : accept null floors #12295

merged 6 commits into from
Dec 3, 2024

Conversation

mkomorski
Copy link
Collaborator

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

#10432

@ChrisHuie ChrisHuie changed the title Price floors module: Accept null floors Price floors module : accept null floors Oct 7, 2024
@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@mkomorski mkomorski force-pushed the mkomorski/price-floors branch from 75180e4 to 3ac680f Compare October 22, 2024 13:22
@github-actions GitHub Actions
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/kargoBidAdapter.js (+1 error)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann patmmccann merged commit d014440 into master Dec 3, 2024
4 of 6 checks passed
@patmmccann patmmccann deleted the mkomorski/price-floors branch December 3, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

@dgirardi dgirardi Awaiting requested review from dgirardi

Assignees

@patmmccann patmmccann

@dgirardi dgirardi

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkomorski @patmmccann @dgirardi