Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting DigiTrustID in GumGum adapter #1256

Merged
merged 2 commits into from
Jun 9, 2017

Conversation

bruscantini
Copy link
Contributor

@bruscantini bruscantini commented Jun 2, 2017

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

In GumGum adapter, retrieving DigiTrust ID, if DigiTrust service is available, and sending to GumGum endpoint.

Other info

JIRA: AT-4979_DigiTrust-POC

anthony added 2 commits June 1, 2017 10:10
…t using it - at least for the moment. And remaned dt.id query param to just dt
@bruscantini bruscantini changed the title At 4979 digi trust poc Getting DigiTrustID in GumGum adapter Jun 2, 2017
@grevory
Copy link
Contributor

grevory commented Jun 2, 2017

LGTM. Same as Rubicon Project Digitrust support with a few minor changes.

@grevory grevory added the LGTM label Jun 5, 2017
@grevory grevory self-requested a review June 8, 2017 20:34
@grevory grevory self-assigned this Jun 8, 2017
@jaiminpanchal27 jaiminpanchal27 self-requested a review June 9, 2017 19:44
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaiminpanchal27 jaiminpanchal27 added this to the Prebid 0.25.0 milestone Jun 9, 2017
@jaiminpanchal27 jaiminpanchal27 merged commit f17ec54 into prebid:master Jun 9, 2017
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Sep 6, 2017
….24.0 to aolgithub-master

* commit '7a81386579a3c129617323ef32e1c8be0897c3c7': (31 commits)
  Added changelog entry.
  Added records in aolPartnersIds.json.
  Prebid 0.25.0 Release
  Added Unruly adapter (prebid#1264)
  Fixing Adyoulike adapter for Safari iOS7 (prebid#1296)
  hide overflow to prevent scrolling (prebid#1294)
  fix protocol detection in iframe (prebid#1293)
  Add eplanning adapter (prebid#1245)
  Use Renderer command queue to render outstream (prebid#1283)
  Generate no-bid response for ech bid request not matched by a bid (prebid#1216)
  New Cox adapter (prebid#1228)
  Carambola Adapter (prebid#1221)
  Pass through transactionId and set fd=1 (prebid#1259)
  Integration test page for adapters (prebid#1182)
  Getting DigiTrustID in GumGum adapter (prebid#1256)
  Trion adapter (prebid#1254)
  use request bidder code as default bidderCode for createBid (prebid#1235)
  Add drop pixels once feature to AOL Adapter (prebid#1224)
  Rubicon Adapter - Adding 320x150 (prebid#1279)
  Prevent 'about:' protocol in _publisherTagUrl (prebid#1170)
  ...
jbAdyoulike pushed a commit to jbAdyoulike/Prebid.js that referenced this pull request Sep 21, 2017
* get DigiTrust ID from DigiTrust Object, if present, and send to our endpoint

* no longer retrieving DigiTech.keyv from DigiTrust object as we are not using it - at least for the moment. And remaned dt.id query param to just dt
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* get DigiTrust ID from DigiTrust Object, if present, and send to our endpoint

* no longer retrieving DigiTech.keyv from DigiTrust object as we are not using it - at least for the moment. And remaned dt.id query param to just dt
@lbenmore lbenmore deleted the AT-4979_DigiTrust-POC branch January 4, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants