-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video support for AdKernel adapter #1270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the video PR. One comment for review, and do you have test parameters we can use for validating bid responses with this change?
src/adapters/adkernel.js
Outdated
width: width, | ||
height: height, | ||
cpm: parseFloat(resp.price) | ||
}); | ||
if (bid.params.video) { | ||
bidObj.vastUrl = resp.nurl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also signify this is a video bid response with bidObj.mediaType = 'video';
, and you may want to add (edit: bidObj.descriptionUrl = resp.nurl;
, which is used in pbjs.buildMasterVideoTagFromAdserverTag
descriptionUrl
isn't required)
@ckbo3hrk Please resolve conflicts and see note about adding |
@matthewlane Everything is done. Also there are the test parameters you've asked for : {
code: 'video_wrapper',
sizes: [640, 480],
mediaType : 'video',
bids: [{ bidder: 'adkernel',
params: {
zoneId : '30164',
host : 'cpm.metaadserving.com'}
}]
} |
Type of change
Description of change
Video support for AdKernel adapter has been added.