Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video support for AdKernel adapter #1270

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Conversation

ckbo3hrk
Copy link
Contributor

@ckbo3hrk ckbo3hrk commented Jun 6, 2017

Type of change

  • Feature

Description of change

Video support for AdKernel adapter has been added.

  • Test parameters for validating bids
{ 
  code: 'video_wrapper',
  sizes: [640, 480],
  mediaType : 'video',
  bids: [{ bidder: 'adkernel',
       params: {
           zoneId : '30164',
           host : 'cpm.metaadserving.com'}
  }]
}

@ckbo3hrk ckbo3hrk closed this Jun 6, 2017
@ckbo3hrk ckbo3hrk reopened this Jun 6, 2017
@matthewlane matthewlane self-assigned this Jun 15, 2017
Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the video PR. One comment for review, and do you have test parameters we can use for validating bid responses with this change?

width: width,
height: height,
cpm: parseFloat(resp.price)
});
if (bid.params.video) {
bidObj.vastUrl = resp.nurl;
Copy link
Collaborator

@matthewlane matthewlane Jun 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also signify this is a video bid response with bidObj.mediaType = 'video';, and you may want to add bidObj.descriptionUrl = resp.nurl;, which is used in pbjs.buildMasterVideoTagFromAdserverTag (edit: descriptionUrl isn't required)

@matthewlane
Copy link
Collaborator

@ckbo3hrk Please resolve conflicts and see note about adding bidObj.mediaType = 'video'; to help us the merge, thanks

@ckbo3hrk
Copy link
Contributor Author

@matthewlane Everything is done. Also there are the test parameters you've asked for :

{ 
  code: 'video_wrapper',
  sizes: [640, 480],
  mediaType : 'video',
  bids: [{ bidder: 'adkernel',
       params: {
           zoneId : '30164',
           host : 'cpm.metaadserving.com'}
  }]
}

@dbemiller dbemiller merged commit 7d53893 into prebid:master Jul 13, 2017
@ckbo3hrk ckbo3hrk deleted the adkernel_video branch December 12, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants