Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubmatic - fix terminating semicolon inside string assignment #1273

Closed
wants to merge 1 commit into from
Closed

Pubmatic - fix terminating semicolon inside string assignment #1273

wants to merge 1 commit into from

Conversation

protonate
Copy link
Collaborator

@protonate protonate commented Jun 6, 2017 •
edited
Loading

The terminating semicolon is put inside the quoted string here and on the next two lines and causes an "Unexpected identifier" error to be thrown when the string is parsed for DOM insertion by iframeDoc.write(_createRequestContent());.

cc: @prebid/pubmatic @ptomasroos

@protonate protonate requested a review from dbemiller June 6, 2017 22:59
protonate referenced this pull request Jun 6, 2017
@ptomasroos @dbemiller
Fixes #998 Allow keyvalues, gender and age to be passed in PubMatic (#…
cf76e85 
…1213)

* Fixes #998 Allow keyvalues, gender and age to be passed in PubMatic's adapter

* Linting and make sure to define variables
@protonate
Copy link
Collaborator Author

Ah already addressed with #1272, closing.

@protonate protonate closed this Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbemiller dbemiller Awaiting requested review from dbemiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@protonate