Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubMatic Analytics Adapter : sending 'ffs' floors param in tracker and optional chaining in logger and tracker #12739

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

pm-asit-sahoo
Copy link
Contributor

@pm-asit-sahoo pm-asit-sahoo commented Feb 7, 2025

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

This PR contains change to send 'ffs' floor param in tracker call.

Other information

@pm-asit-sahoo pm-asit-sahoo changed the title PubMatic Analytics Adapter: Sending 'ffs' floors param in tracker WIP: PubMatic Analytics Adapter: Sending 'ffs' floors param in tracker Feb 7, 2025
@pm-asit-sahoo pm-asit-sahoo changed the title WIP: PubMatic Analytics Adapter: Sending 'ffs' floors param in tracker PubMatic Analytics Adapter: Sending 'ffs' floors param in tracker Feb 11, 2025
@pm-asit-sahoo pm-asit-sahoo marked this pull request as ready for review February 11, 2025 11:21
@ChrisHuie ChrisHuie self-requested a review February 13, 2025 09:18
@ChrisHuie ChrisHuie self-assigned this Feb 13, 2025
@pm-asit-sahoo pm-asit-sahoo changed the title PubMatic Analytics Adapter: Sending 'ffs' floors param in tracker PubMatic Analytics Adapter: Sending 'ffs' floors param in tracker and fix for 'ds' Feb 14, 2025
@pm-asit-sahoo pm-asit-sahoo changed the title PubMatic Analytics Adapter: Sending 'ffs' floors param in tracker and fix for 'ds' PubMatic Analytics Adapter: Sending 'ffs' floors param in tracker and optional chaining in logger and tracker Feb 14, 2025
@pm-asit-sahoo
Copy link
Contributor Author

Hi @ChrisHuie - Conflicts are resolved. PR is ready for review. Thanks

@ChrisHuie ChrisHuie changed the title PubMatic Analytics Adapter: Sending 'ffs' floors param in tracker and optional chaining in logger and tracker PubMatic Analytics Adapter : sending 'ffs' floors param in tracker and optional chaining in logger and tracker Feb 19, 2025
@ChrisHuie ChrisHuie merged commit ed011ea into prebid:master Feb 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants