Add network zone matching to criteo adapter #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbemiller
reviewed
Jul 12, 2017
modules/criteoBidAdapter.js
Outdated
| ) | ||
| ); | ||
|
|
||
| if (!networkid && bid.params.networkId != undefined) { |
There was a problem hiding this comment.
Is there any way for networkid to be defined here? I don't see any assignments between here and its declaration.
There was a problem hiding this comment.
agree, doesn't need to be there.
mkendall07
approved these changes
Jul 13, 2017
|
@Swiiip thanks for this addition. We are currently testing the sizes parameter and are wondering how the criteo ad server must be configured to handle multiple sizes per zoneId. At the moment we send a bid request per zoneId/size combination, which leads to multiple bid responses per ad unit. Prebid is not designed to handle this and chooses the last bid response, not taking the cpm into account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add network zone matching feature for Criteo Adapter