convert targeting module to factory pattern #1606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dbemiller
reviewed
Sep 22, 2017
| var pbTargetingKeys = []; | ||
|
|
||
| targeting.resetPresetTargeting = function(adUnitCode) { | ||
| if (isGptPubadsDefined()) { | ||
| export function newTargeting() { |
There was a problem hiding this comment.
As written, all these instances are hardcoded to depend on two pieces of mutable/global state: $$PREBID_GLOBAL$$ (through getBidLandscapeTargeting and getAlwaysUseBidTargeting) and the bidmanager (through getStandardKeys).
These two things should be arguments here, with the globals passed in in the export const targeting line.
That will make it possible (for someone else--unless you want to tackle it here) to clear the unit tests of the issues that @mkendall07 ran into in #1427, and bring the project one step closer to #1508.
|
Declining as we need to re-write targeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Convert targeting module to factory pattern.