-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AdButler adapter for Prebid v1.0 #1664
Merged
+343
−619
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
771b74c
Adding AdButler Adapter
dkharton 45919de
Prevent AdButler TypeError
dharton 5e72aac
Refactor AdButler Testing
dharton 10ab721
Prevent AdButler TypeErrors
dharton 38ad684
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton 79e7045
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton 7fe5aa1
Merge remote-tracking branch 'prebid/master'
dharton 1cf22f4
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton eca8d59
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton 252ffac
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton add7a75
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton 35b8180
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton 2cdc25b
Merge branch 'master' of https://github.com/sparklit/Prebid.js
dharton f4cac5d
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton c0ef919
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton 8f85d45
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton 1d4480a
Add optional domain parameter.
dharton 4efc579
Merge remote-tracking branch 'refs/remotes/prebid/master'
dharton 42b3c41
Merge remote-tracking branch 'remotes/prebid/master'
dharton 28df88d
Merge remote-tracking branch 'remotes/prebid/master'
dharton 5cc58bf
Merge remote-tracking branch 'remotes/prebid/master'
dharton cdea438
Merge remote-tracking branch 'remotes/prebid/master'
dharton 09804e4
Update AdButler adapter to Prebid 1.0
dharton 0117275
Code Style updates based on lint warnings.
dharton 5af952b
Removed mutable global, simplified tests, and added markdown file.
dharton 7ef0341
Update c1x adapter tests & remove old adbutler_spec file.
dharton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Overview | ||
|
||
**Module Name**: AdButler Bidder Adapter | ||
**Module Type**: Bidder Adapter | ||
**Maintainer**: dan@sparklit.com | ||
|
||
# Description | ||
|
||
Module that connects to an AdButler zone to fetch bids. | ||
|
||
# Test Parameters | ||
``` | ||
var adUnits = [ | ||
{ | ||
code: 'display-div', | ||
sizes: [[300, 250]], // a display size | ||
bids: [ | ||
{ | ||
bidder: "adbutler", | ||
params: { | ||
accountID: '167283', | ||
zoneID: '210093', | ||
keyword: 'red', //optional | ||
minCPM: '1.00', //optional | ||
maxCPM: '5.00' //optional | ||
} | ||
} | ||
] | ||
} | ||
]; | ||
``` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapters shouldn't add tracking pixels during the auction anymore. Implement getUserSyncs instead.
prebid-core
will make sure those pixels get added to the page alongside everyone else'sThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info @dbemiller. We offer our customers the option to track impressions on the client-side. If they've chosen this, their impression pixel would have been added here. Just to verify, if the publisher has userSync disabled, this means there is a chance their impression wouldn't be counted in this way. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Since tracking pixels affect the publisher's page performance, the prebid leadership decided that they should have the ultimate decision in whether or not to allow them.
That said, most publishers leave the default options... so it's not likely to impact you too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the desire to improve publisher page performance. My only concern is that when all syncs are blocked, the winning bidder will not have any way to know that they have won a particular auction. Is there any way for us to provide Prebid with a URL that can be pinged or placed if our bid has won the auction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be some confusion here. It's acceptable to add a tracking pixel to a bid response. This will only fire if the bid wins the auction. I think that's what this is so should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the clarification. Yeah, this function just appends the tracking pixel(s) to the ad code in the bid response.