Platform.io Bidder Adapter update. Prebid v1.0. #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params
## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params
Update platformioBidAdapter
Endpoint URL change
Endpoint URL change
matthewlane
reviewed
Oct 19, 2017
There was a problem hiding this comment.
Thanks for the updated adapter, I was able to verify bid responses with the provided test parameters. A few line removals requested below. Also it looks like all three files in the PR have CRLF/Windows-style line endings, preferably update these to have LF/Unix-style line endings to be consistent with the other file in the project
| $$PREBID_GLOBAL$$._bidsReceived = []; | ||
| import {expect} from 'chai'; | ||
| import {spec} from 'modules/platformioBidAdapter'; | ||
| import bidManager from 'src/bidmanager'; |
There was a problem hiding this comment.
bidManager isn't used in the test, line can be removed
| import {spec} from 'modules/platformioBidAdapter'; | ||
| import bidManager from 'src/bidmanager'; | ||
| import {getTopWindowLocation} from 'src/utils'; | ||
| import {newBidder} from 'src/adapters/bidderFactory'; |
There was a problem hiding this comment.
newBidder isn't used in the test, line can be removed
modules/platformioBidAdapter.js
Outdated
| var adloader = require('src/adloader.js'); | ||
| var utils = require('src/utils.js'); | ||
| var CONSTANTS = require('src/constants.json'); | ||
| var adaptermanager = require('src/adaptermanager'); | ||
|
|
There was a problem hiding this comment.
Preferable to start files with content rather than a blank line, line can be removed
|
@matthewlane Hey, thanks for the feedback. Everything was updated, please verify. Looking forward to you reply. |
matthewlane
approved these changes
Oct 23, 2017
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Oct 25, 2017
* 'master' of https://github.com/prebid/Prebid.js: (414 commits) Make response headers available to the specs (prebid#1748) add option to run tests in a specific file (prebid#1727) Update JCM Adapter to 1.0 (prebid#1715) Finished an unfinished comment. (prebid#1749) Platform.io Bidder Adapter update. Prebid v1.0. (prebid#1705) Fix window.top.host cross origin issue when in nested iframes. (prebid#1730) fix log message not displaying when referencing missing bidder (prebid#1737) Allow more than one placement from one page (prebid#1692) Justpremium Adapter bugfix (prebid#1716) Updating license (prebid#1717) realvuBidAdapter (prebid#1571) Update JSDoc to call the module `pbjs` (prebid#1572) Update Beachfront adapter for v1.0 (prebid#1675) Update AdButler adapter for Prebid v1.0 (prebid#1664) Increment pre version Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Platform.io Bidder Adapter update. Prebid v1.0.
Adapter does not support external JS library
Other information