Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenX Adapter update to Prebid v1.0 #1714

Merged
merged 3 commits into from
Nov 1, 2017
Merged

OpenX Adapter update to Prebid v1.0 #1714

merged 3 commits into from
Nov 1, 2017

Conversation

lntho
Copy link
Contributor

@lntho lntho commented Oct 18, 2017

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Update OpenX adapter to Prebid v1.0 specs

matthewlane
matthewlane reviewed Oct 18, 2017
View reviewed changes
Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated adapter. Please also add your .md file in this PR: http://prebid.org/dev-docs/bidder-adapter-1.html#planning-your-adapter

@rjvelicaria
Copy link
Contributor

@matthewlane Added the markdown. Is there anything else that we forgot to put in?

@lntho lntho force-pushed the prebid-1.0-oxadapterupdate-master branch from 1cc79ff to 57cef50 Compare October 23, 2017 17:27
@matthewlane
Copy link
Collaborator

#1724 looks like an updated version of this PR, should this PR be closed in favor of that one?

@lntho
Copy link
Contributor Author

lntho commented Oct 25, 2017

@matthewlane We have decided to submit this PR first and submit the PR for video as another PR to our adapter later. I will update this PR to fix any comments the other PR had shortly.

@lntho lntho force-pushed the prebid-1.0-oxadapterupdate-master branch from 57cef50 to 2bdd6c4 Compare October 25, 2017 21:33
@lntho lntho force-pushed the prebid-1.0-oxadapterupdate-master branch from 2bdd6c4 to 201e1f6 Compare October 25, 2017 22:00
@IHateCodesss IHateCodesss mentioned this pull request Oct 25, 2017
Merged
8 tasks
@matthewlane
Copy link
Collaborator

@lntho Ok, looks like this was updated to fix comments from the other PR, we'll work on getting this merged first. Only holdup is that I'm getting empty bid responses with the test parameters from openxBidAdapter.md, please advise. Once bid response are validated we should be good to go

@lntho
Copy link
Contributor Author

lntho commented Oct 27, 2017

@matthewlane Thanks for the review. I have updated the ad unit as well as the size it can receive, this one should work now. Please let me know if it doesn't. Thanks again!

@matthewlane
Copy link
Collaborator

Hmm, still no luck with the updated parameters. What I'm doing is taking those and putting them on the hello_world test page, updating the sizes to [[728, 90]], running gulp serve, and opening the page in a browser. Checking pbjs.getBidResponses() in the console, OpenX has a statusMessage of "Bid returned empty or error response". Are you getting different results in this setup?

@lntho
Copy link
Contributor Author

lntho commented Nov 1, 2017

@matthewlane Apologies for the late response, I was out yesterday. I have updated to a new ad unit that I have tested with the hello_world test page and it should work. Please let me know if it doesn't.

matthewlane
matthewlane approved these changes Nov 1, 2017
View reviewed changes
Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those params are working now, thanks

@matthewlane matthewlane merged commit d818de4 into prebid:master Nov 1, 2017
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@lntho @dluxemburg
OpenX Adapter update to Prebid v1.0 (prebid#1714)
3b18fe2 
* OpenX Adapter update to Prebid v1.0

* Updated the ad unit in the OpenX md file

* Updated the test ad unit again to something that should work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlane matthewlane matthewlane approved these changes

Assignees

@matthewlane matthewlane

Labels
LGTM Prebid 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lntho @rjvelicaria @matthewlane @jaiminpanchal27 @mjacobsonny