Prebid 1.0 compliant Komoona bidder adapter #1743
Conversation
|
Prebid 1.0 compliant Komoona bidder adapter |
modules/komoonaBidAdapter.js
Outdated
| export const spec = { | ||
| code: BIDDER_CODE, | ||
|
|
||
| aliases: ['komoona'], |
There was a problem hiding this comment.
This is just for adapters which have multiple names... since this is the same as your BIDDER_CODE, you can just delete it.
There was a problem hiding this comment.
Removed from adapter file, thanks from the comment
| bid.requestId = bid.uuid; | ||
| // The creative payload of the returned bid. | ||
| bid.ad = bid.creative; | ||
| bidResponses.push(bid); |
There was a problem hiding this comment.
There are lots of required params missing from these bids. See: https://github.com/prebid/Prebid.js/pull/1738/files#diff-ac0af2601dcafed83fa9a11b814bf3b5L109
There was a problem hiding this comment.
Our md file was updated with correct placement Id and hb Id for test creative (as well as our servers) and now when using placementId and hbId from md file, the hello_world file will always return a creative
There was a problem hiding this comment.
Working to fix it, it was added to our servers and now testing it out - will ping once live and fixed
|
CI test error was fixed, sorry for that - now Komoona gulp test and lint test pass. |
|
I did a bit of debugging... it looks like the changes in #1742 are causing you problems. We had to make a breaking change to support their use case and maintain a reasonably clean adapter API. That probably explains our confusion, too... I've been testing with the latest changes from It's a small change. Rather than |
dbemiller
added
not receiving bids
needs update
and removed
needs update
not receiving bids
labels
…, the bidderFactory is calling your adapter with interpretResponse({ body: body, ... })
|
Thanks for the comment and pointing to correct change - we have sync our fork with master and change adapter to match change #1742 |
|
Looks good now... thanks! |
|
|
||
| it('handles JSON.parse errors', () => { | ||
| server.respondWith(''); | ||
| describe('Verify komoonaAdapter build request', () => { |
There was a problem hiding this comment.
These test cases need to be it block for 2 reasons.
- karma is not showing actual count of tests in logs. So even though this is getting executed but count is not correct. I placed it in
itblock and test count was incremented. - If this test fails than it stops here itself.
There was a problem hiding this comment.
True comment and I accept it - we actually use it for internal products test, not sure why describe was used (probably just copied from old test).
It is fixed now
* Prebid 1.0 compliant bidder adapter * PlacementId and hbId support display test banner * Remove aliases * remove check for aliases, breaks build * Add bid response test with mandatory params * change prebid#1742 (prebid#1742): rather than interpretResponse(body), the bidderFactory is calling your adapter with interpretResponse({ body: body, ... }) * replace describe with it
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
Other information