Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerBid Server BidAdapter #1803

Closed
wants to merge 1 commit into from

Conversation

jcswart
Copy link
Contributor

@jcswart jcswart commented Nov 3, 2017

Allow S2S configuration with ServerBid.

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Add S2S adapter: ServerBidServerBidAdapter.

Other information

Allow S2S configuration with ServerBid.
@dbemiller
Copy link
Contributor

hey @jcswart ... thanks for the PR, but we're getting ready to release Prebid 1.0, and stopped accepting PRs for "old style" adapters quite a while ago.

Please update your adapter so that it conforms to the 1.0 standards. http://prebid.org/dev-docs/bidder-adapter-1.html

@dbemiller dbemiller closed this Nov 8, 2017
@jcswart
Copy link
Contributor Author

jcswart commented Nov 9, 2017

@dbemiller this is for a new server to server adapter. Not a regular bid adapter.

How does it not conform to the new standards? As far as I can tell there is only one other server to server adapter, and that is for prebid. This adapter is compatible with the same style of input.

@jcswart
Copy link
Contributor Author

jcswart commented Nov 9, 2017

I've opened #1819 as it fixes an issue with linting. Otherwise the above comment is in effect.

@dbemiller
Copy link
Contributor

@jcswart yes... the prebid-server one is out of compliance too. @snapwich is working on updating it right now.

I definitely didn't realize that this was an s2s adapter. I'm not sure whether that changes anything, with regards to the standards... but will run it by the team/leadership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants