Populate adtypes array #1862
Merged
Populate adtypes array #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
approved these changes
Nov 27, 2017
jsnellbaker
added a commit
that referenced
this pull request
Nov 28, 2017
This reverts commit 214ba19.
jsnellbaker
added a commit
that referenced
this pull request
Nov 28, 2017
* Revert "Postbid bugfix (#1844)" This reverts commit 2e7783a. * Revert "Populate adtypes array (#1862)" This reverts commit 214ba19. * Revert "Pass bidderRequestId parameter in Adform adapter (#1888)" This reverts commit 59800f4. * Revert "Add Arteebee bidder adapter (#1849)" This reverts commit 18fe42d. * Revert "fix linting errors for trailing spaces (#1889)" This reverts commit d41287a. * Revert "Randomize pbjs global name when testing (#1787)" This reverts commit f9cb0dd.
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* wip * Populate ad_types on all requests * Use constants for media types * Cover outstream requests
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Revert "Postbid bugfix (prebid#1844)" This reverts commit 2e7783a. * Revert "Populate adtypes array (prebid#1862)" This reverts commit 214ba19. * Revert "Pass bidderRequestId parameter in Adform adapter (prebid#1888)" This reverts commit 59800f4. * Revert "Add Arteebee bidder adapter (prebid#1849)" This reverts commit 18fe42d. * Revert "fix linting errors for trailing spaces (prebid#1889)" This reverts commit d41287a. * Revert "Randomize pbjs global name when testing (prebid#1787)" This reverts commit f9cb0dd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Currently only 'native' ad units set the
ad_typesarray on/utrequests. This PR sets thead_typesarray for every request made to/ut, based on the ad unit media type. If no media type is specified, defaults to bannerAlso refactors the adapter to use the constants provided by
src/mediaTypesrather than strings