Change clone function to make deep copies #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Dec 4, 2017
src/utils.js
Outdated
| @@ -643,8 +644,8 @@ export function isSrcdocSupported(doc) { | |||
| 'srcdoc' in doc.defaultView.frameElement && !/firefox/i.test(navigator.userAgent); | |||
| } | |||
|
|
|||
| export function cloneJson(obj) { | |||
| return JSON.parse(JSON.stringify(obj)); | |||
| export function clone(obj) { | |||
There was a problem hiding this comment.
should we call this deepClone?
mkendall07
approved these changes
Dec 4, 2017
mkendall07
reviewed
Dec 4, 2017
| @@ -107,6 +107,7 @@ | |||
| "dependencies": { | |||
| "babel-plugin-transform-object-assign": "^6.22.0", | |||
| "core-js": "^2.4.1", | |||
| "gulp-sourcemaps": "^2.6.0" | |||
| "gulp-sourcemaps": "^2.6.0", | |||
| "just-clone": "^1.0.2" | |||
jaiminpanchal27
approved these changes
Dec 4, 2017
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Dec 8, 2017
* 'master' of https://github.com/prebid/Prebid.js: (43 commits) Merge Prebid 1.0 to Master (prebid#1936) Prebid.js 0.34.1 release Vertamedia adapter outstream support (prebid#1860) Expose native image-type asset dimensions on bid response object (prebid#1919) Remove for of (prebid#1932) Unit-test fix (prebid#1927) Remove description_url (prebid#1922) Trion Interactive Adapter Bugfix (prebid#1925) Remove config setting from Optimatic adapter (prebid#1909) IE bug fix (prebid#1930) Clarify ad unit media filtering warning (prebid#1903) Add ReadPeak Bid Adapter (prebid#1838) Change clone function to make deep copies (prebid#1910) Serverbid 1.0 (prebid#1802) sekindoUM for prebid1.0 (prebid#1777) update auctionId to be requestId (prebid#1896) bug fixed to populate userSync default values (prebid#1897) Increment pre version AdkernelAdn analytics adapter (prebid#1868) Justpremium Adapter: use `filter` instead of `...new Set` (prebid#1895) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Dec 28, 2017
….34.0 to aolgithub-master * commit 'f0ba90afa8b52de7a646d43928b2d51ee42e74a1': (53 commits) Added changelog entry. Added partners ids. Added dynamic ttl property for One Display and One Mobile. Prebid.js 0.34.1 release Vertamedia adapter outstream support (prebid#1860) Expose native image-type asset dimensions on bid response object (prebid#1919) Remove for of (prebid#1932) Unit-test fix (prebid#1927) Remove description_url (prebid#1922) Trion Interactive Adapter Bugfix (prebid#1925) Remove config setting from Optimatic adapter (prebid#1909) IE bug fix (prebid#1930) Clarify ad unit media filtering warning (prebid#1903) Add ReadPeak Bid Adapter (prebid#1838) Change clone function to make deep copies (prebid#1910) Serverbid 1.0 (prebid#1802) sekindoUM for prebid1.0 (prebid#1777) update auctionId to be requestId (prebid#1896) bug fixed to populate userSync default values (prebid#1897) Increment pre version ...
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Change clone function to make deep copies * Rename function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Changes
utils.cloneJsonto perform a deep copy. This resolves situations where functions on objects were not being copied by the utility. The utility function was also renamed to reflect the fact that it now does a full clone rather than parsing by JSON, which drops functions.Other information
Uses
just-clonelibrary, which adds ~176 bytes to the production buildFixes #1869
Fixes #1878