-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eplanningBidAdapter #2003
Add eplanningBidAdapter #2003
Conversation
Hi @dbemiller, could this be reviewed? I know you are busy but we would like to be compatible with 1.0 asap |
@sebaperez I do minimal work on Prebid.js these days... my main focus is on Prebid Server. Most everyone involved on both projects was out last week, but one of the Prebid.js maintainers will get to it whenever they have bandwidth. |
The user sync generating a 404 because the url is being set to the string 'sync' which causes the browser to try load an object called 'sync' relative to the current page
|
The other thing I noted, the returned test ad is just text. Most adapters test ad is an image |
@mike-chowla Thanks for the feedback. I just fixed the sync, and changed the test ad to an image (this needs to be deployed) |
Doesn't look like the test ad image deployed but otherwise looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With fixes looks, good.
@mike-chowla thank you so much for reviewing! |
@sebaperez, I've already enter my review as 'approved' so you are good from my end. I understand waiting to get your 1.0 code out :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 'master' of https://github.com/prebid/Prebid.js: (23 commits) Update Atomx adapter for Prebid v1.0 (prebid#2026) Add vi bid adapter (prebid#2020) Add eplanningBidAdapter (prebid#2003) OpenX Adapter: Update to support mediaTypes field, instead of the deprecated mediaType field (prebid#1974) Separate bids & won calls (prebid#2015) 1.0 adapter support for mantis (prebid#1840) Media.net adapter added (prebid#2038) GumGum Adapter for Prebid.js 1.0 (prebid#1966) Serverbid Bid Adapter: updated docs and ad sizes (prebid#2023) Adding districtm as an alias (prebid#2018) Use sudo to workaround Travis regression (prebid#2041) Fix uncached video bids triggering callback early (prebid#2017) Re-implemented RhythmOne audit beacon in prebid 1.0 interface (prebid#1953) Add NasmediaAdmixer adapter for Perbid.js 1.0 (prebid#1937) Update Adform adapter to Prebid v1.0 (prebid#1947) Upgrade Admixer adapter for Prebid 1.0 (prebid#1755) multiformat size validation checks (prebid#1964) Gjirafa Bidder Adapter (prebid#1944) pin gulp-connect at non-broken version (prebid#2008) Added dynamic ttl property for One Display and One Mobile. (prebid#2004) ...
Added the needs-docs label since it's not showing up on http://prebid.org/download.html in the 1.2.0 dropdown due to lack of the page having the "prebid 1.0 support" key in the page's YAML header. |
@rmloveland I just opened a pr in prebid.org website repo (ref prebid/prebid.github.io#586) |
* Add eplanningBidAdapter * Add new parameter to request * Fix sync URL parameter
Type of change
Description of change
This PR adds the eplanningBidAdapter, which was removed because the old version did not comply with the new 1.0 requirements.
Other information
The bidder parameters have not changed so the documentation doesn't need to be updated.
An important note: the adserver code needs a small update (it will be done in the next few days) before it can correctly answer in the format the adapter expects (the test adunit does work correctly, though), I'm submitting the PR now so we can be sure the adapter is correctly verified.
Thanks!