Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colossus SSP header bidding adapter 1.0.0 #2029

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Colossus SSP header bidding adapter 1.0.0 #2029

merged 2 commits into from
Jan 23, 2018

Conversation

HuddledMasses
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Add adapter and tests for the Colossus SSP header bidding adapter

  • test parameters for validating bids
{
   bidder: 'colossusssp',
   params: {
      placement_id: 0
    }
}

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also submit a PR to update your bidder file in the docs repo, to add the line prebid_1_0_supported : true to the header, and make any updates to the bidder params if necessary

@HuddledMasses
Copy link
Contributor Author

@matthewlane please check, here it is: https://github.com/prebid/prebid.github.io/pull/560

@jaiminpanchal27 jaiminpanchal27 merged commit 6cfaa5c into prebid:master Jan 23, 2018
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Jan 24, 2018
* 'master' of https://github.com/prebid/Prebid.js:
  Prebid 1.2.0 Release
  Use polyfilled includes method (prebid#2061)
  RockYou Adapter: Added RockYou Adapter supporting Prebid 1.0 (prebid#1977)
  Optimera Adapter for 1.0. (prebid#1961)
  Use cross-browser integer check (prebid#2058)
  Fix skipped test (prebid#2059)
  Support multiple media formats within a single ad unit (prebid#1991)
  pre1api module that allows use of deprecated pre1.0 API in Prebid 1.0 (prebid#1976)
  Colossus SSP header bidding adapter 1.0.0 (prebid#2029)
  InSkin Bidder Adapter (prebid#2016)
  Update adapter to prebid v1.0 (prebid#1908)
  PubMatic 1.0 adapter (prebid#2011)
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* create adapter colossusssp

* Trigger for current build rerun on Travis CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants