Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media.net adapter added #2039

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Conversation

vedantseta
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

The PR adds Media.net adapter

  • test parameters for validating bids.
var adUnits = [{
          code: 'div-gpt-ad-1460505748561-0',
          sizes: [[300, 250], [300,600]],
  
          bids: [{
              bidder: 'medianet',
              params: {
                  cid : '8CUX0H51C',
                  site: {
                      page: 'http://smoketesting.net/prebidtest',
                      domain: 'smoketesting.net',
                      ref: 'http://smoketesting.net/prebidtest'
                  }
              }
          }]

     }];

PR on the docs repo at prebid/prebid.github.io#549

@vedantseta
Copy link
Contributor Author

@mkendall07 , Getting this error on Travis
Cannot start ChromeHeadless

Could you check ?
Thanks.

@vedantseta
Copy link
Contributor Author

@mkendall07 Thanks for applying Travis patch in master. Can you please apply the same patch in legacy branch too ?

Thanks.

@mkendall07
Copy link
Member

@vedantseta
done. thx

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on legacy branch, works equivalently to corresponding 1.0 adapter and receiving bids. LGTM

@jaiminpanchal27 jaiminpanchal27 merged commit 850ef82 into prebid:legacy Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants