Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update creative.js #2071

Closed

Conversation

AntoineJac
Copy link
Contributor

2 small fix:
1- append scripts after all html node are append
2- add small regex in case the string is malformed

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

2 small fix:
1- append scripts after all html node are append
2- add small regex in case the string is malformed
@bretg
Copy link
Collaborator

bretg commented Jan 29, 2018

@mkendall07 - since you're working on the AMP-RTC creative, thought it made sense for you to take a look at this small PR.

@bretg
Copy link
Collaborator

bretg commented Jan 29, 2018

@AntoineJac - this PR might need to be rebased to pass CI. See #2042

@mkendall07
Copy link
Member

yeah thanks Bret. The rebase is on me.

@mkendall07
Copy link
Member

@mkendall07 mkendall07 closed this Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants