Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adform adapter request #2107

Merged
merged 57 commits into from
Feb 6, 2018
Merged

Update adform adapter request #2107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
10edde0
bid response adId same as bidId
braizhas Jan 24, 2017
8596825
Merge branch 'upmaster'
braizhas May 2, 2017
11d1404
Merge pull request #10 from prebid/master
Pupis Jun 13, 2017
3aa3b53
test
Nov 8, 2017
84f662c
update adform bid adapter
Nov 8, 2017
a6dbc4a
update unit tests
Nov 8, 2017
2f74c76
Added adform adapter description file
Nov 8, 2017
0fc8d12
updated tests
Nov 8, 2017
f6a51be
Another tests update
Nov 8, 2017
25299b8
Add auctionId
Nov 27, 2017
6891ecd
Update adapter for auctionId
Nov 27, 2017
3551b0c
Merge commit '02d2d4cd236d22fe469cbaff868b49e192ec2ab6' into temp-merge
Nov 28, 2017
5350442
Merge branch 'adform-auctionId' of https://github.com/adform/Prebid.j…
Nov 28, 2017
a7b9408
add auctionId to adformBidAdapter
Nov 28, 2017
dfa383b
Merge commit 'ef4ffdb590c6d673b8c3c3ceb76f756e52c41c31'
Dec 4, 2017
11c7924
Merge branch 'master' of https://github.com/prebid/Prebid.js
Dec 8, 2017
29e7931
Final updates to fit 1.0 version
Dec 11, 2017
648ed8a
Merge branch 'adform-adapter-update' into origin master
Dec 11, 2017
138f956
update docs and integration example
Dec 11, 2017
8df70f0
Do not mutate original validBidRequests
Dec 14, 2017
4e6a0ee
use atob and btoa instead of custom made module
Dec 14, 2017
2879bd4
Renaming one query string parameter
Jan 3, 2018
bdc19fd
XDomainRequest.send exception fix (#1942)
ckbo3hrk Dec 11, 2017
0b39bd7
Added YIELDONE Bid Adapter for Prebid.js 1.0 (#1900)
Dec 12, 2017
ef3a823
Add user-facing docs reminder to PR template (#1956)
rmloveland Dec 14, 2017
a17ebaf
allow non-mappable sizes to be passed and used in rubicon adapter (#1…
snapwich Dec 15, 2017
d13f7ce
Typo correction of YIELDONE md file (#1954)
Dec 19, 2017
a340bb1
Serverbid bid adapter: update alias config (#1963)
jgrimes Dec 19, 2017
8e15c0d
use auctionId instead of requestId (#1968)
jaiminpanchal27 Dec 19, 2017
3caf481
Add freewheel ssp bidder adapter for prebid 1.0 (#1793)
guillaume-sticky Dec 19, 2017
49668ec
+ fixed endpoint request data property names - width to w and height …
optimatic58 Dec 19, 2017
48aece8
Added iQM Bid Adapter for Prebid.js 1.0 (#1880)
pkthakkar26 Dec 19, 2017
8166a3b
Remove stray console.log (#1975)
matthewlane Dec 19, 2017
b038a30
Remove duplicate request id and fix empty response from getHighesCpmB…
jaiminpanchal27 Dec 19, 2017
b3e7489
[Add BidAdapter] rxrtb adapter for Perbid.js 1.0 (#1950)
prebidRxRTB Dec 19, 2017
f993ab0
ServerBid Server BidAdapter (#1819)
jcswart Dec 19, 2017
861b0be
added hb_source to default keys (#1969)
Dec 19, 2017
c99ae64
Prebid 1.1.0 Release
matthewlane Dec 20, 2017
f7d9415
Increment pre version
matthewlane Dec 20, 2017
38ca2c5
S2s defaults fix in serverbidServerBidAdapter (#1986)
jaiminpanchal27 Dec 20, 2017
b1f5745
remove hardcoded localhost port for tests (#1988)
snapwich Dec 20, 2017
8f6c6ad
Fixes unit tests in browsers other than chrome (#1987)
jaiminpanchal27 Dec 20, 2017
10f3a87
Prebid 1.1.1 Release
jaiminpanchal27 Dec 20, 2017
fbdd17f
Add note about docs needed before merge (#1959)
Jan 2, 2018
c414949
Adding optional width and height to display parameters (#1998)
nissSK Jan 3, 2018
dbbc00a
TrustX adapter update (#1979)
PWyrembak Jan 3, 2018
20bc6b0
Serverbid Bid Adapter: Add new ad sizes (#1983)
jgrimes Jan 3, 2018
df346f7
Added dynamic ttl property for One Display and One Mobile. (#2004)
vzhukovsky Jan 4, 2018
15e5f5c
pin gulp-connect at non-broken version (#2008)
snapwich Jan 4, 2018
cf3bf61
Gjirafa Bidder Adapter (#1944)
agon-qurdina Jan 4, 2018
d4712be
multiformat size validation checks (#1964)
jsnellbaker Jan 5, 2018
955f399
Upgrade Admixer adapter for Prebid 1.0 (#1755)
Galphimbl Jan 8, 2018
033ed42
Add NasmediaAdmixer adapter for Perbid.js 1.0 (#1937)
NasmediaWebtech Jan 10, 2018
cf2a5ae
Merge branch 'upmaster'
Jan 10, 2018
fba153d
Merge branch 'upmaster'
Feb 1, 2018
4da6bb0
Merge branch 'upmaster'
Feb 5, 2018
24793e8
Updated stid and unit tests
Feb 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/adformBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {registerBidder} from 'src/adapters/bidderFactory';
const BIDDER_CODE = 'adform';
export const spec = {
code: BIDDER_CODE,
supportedMediaTypes: [],
isBidRequestValid: function (bid) {
return !!(bid.params.mid);
},
Expand Down Expand Up @@ -35,7 +34,7 @@ export const spec = {

request.unshift('//' + globalParams[0][1] + '/adx/?rp=4');

request.push('stid=' + validBidRequests[0].requestId);
request.push('stid=' + validBidRequests[0].auctionId);

for (i = 1, l = globalParams.length; i < l; i++) {
_key = globalParams[i][0];
Expand Down
8 changes: 4 additions & 4 deletions test/spec/modules/adformBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe('Adform adapter', () => {
adxDomain: 'adx.adform.net'
};
assert.isFalse(spec.isBidRequestValid(bid));
})
});
});

describe('buildRequests', () => {
Expand Down Expand Up @@ -147,36 +147,36 @@ describe('Adform adapter', () => {
bids = [
{
adUnitCode: placementCode[0],
auctionId: '7aefb970-2045',
bidId: '2a0cf4e',
bidder: 'adform',
bidderRequestId: '1ab8d9',
params: params[0],
adxDomain: 'newDomain',
tid: 45,
placementCode: placementCode[0],
requestId: '7aefb970-2045',
sizes: [[300, 250], [250, 300], [300, 600], [600, 300]],
transactionId: '5f33781f-9552-4ca1'
},
{
adUnitCode: placementCode[1],
auctionId: '7aefb970-2045',
bidId: '2a0cf5b',
bidder: 'adform',
bidderRequestId: '1ab8d9',
params: params[1],
placementCode: placementCode[1],
requestId: '7aefb970-2045',
sizes: [[300, 250], [250, 300], [300, 600], [600, 300]],
transactionId: '5f33781f-9552-4iuy'
},
{
adUnitCode: placementCode[2],
auctionId: '7aefb970-2045',
bidId: '2a0cf6n',
bidder: 'adform',
bidderRequestId: '1ab8d9',
params: params[2],
placementCode: placementCode[2],
requestId: '7aefb970-2045',
sizes: [[300, 250], [250, 300], [300, 600], [600, 300]],
transactionId: '5f33781f-9552-7ev3'
}
Expand Down