Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NURL and ADM as backup #2112

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

optimatic58
Copy link
Contributor

Type of change

  • Feature

Description of change

  • Added support for NURL and ADM as backup
  • Updated unit tests to test code updates
  • Added version number (1.0.4) for optimatic records

+ Updated unit tests to test code updates
+ Added version number (1.0.4) for optimatic records
@snapwich snapwich self-requested a review February 7, 2018 19:28
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich added the LGTM label Feb 7, 2018
@matthewlane matthewlane self-requested a review February 7, 2018 21:16
@matthewlane matthewlane self-assigned this Feb 7, 2018
@matthewlane matthewlane merged commit 8bd9595 into prebid:master Feb 8, 2018
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Feb 12, 2018
* 'master' of https://github.com/prebid/Prebid.js: (51 commits)
  Update maintainer email (prebid#2132)
  Replace event string with constant (prebid#2128)
  Add adapter for IAS (prebid#2056)
  Fix sovrn dealid (prebid#2119)
  Added support for NURL and ADM as backup (prebid#2112)
  fix bug where hooked functions w/ no hooks weren't ran immediately (prebid#2115)
  Increment pre version
  Prebid 1.3.1 Release
  Omit app and device if not present rather than send false (prebid#2116)
  Increment pre version
  Prebid.js 1.3.0 Release
  Unit test fixes (prebid#2111)
  must explicitly list pre1api for it to be included in build (prebid#2097)
  adkernel adapter additional bid parameters (prebid#2105)
  removing userSync (prebid#2032)
  33across Bid Adapter: Bugfix + Refactor (prebid#2024)
  Port calling order fix to 1.x  (prebid#2067)
  Update adform adapter request (prebid#2107)
  Serverbid Bid Adapter: getUserSyncs and new adsizes (prebid#2106)
  Add hfa and pv parameter to request payload (prebid#2109)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
+ Updated unit tests to test code updates
+ Added version number (1.0.4) for optimatic records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants