Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SARA-HB Bid Adapter #2172

Merged
merged 3 commits into from
Apr 13, 2018
Merged

Add SARA-HB Bid Adapter #2172

merged 3 commits into from
Apr 13, 2018

Conversation

SARA-HB
Copy link
Contributor

@SARA-HB SARA-HB commented Feb 21, 2018

Type of change

  • New bidder adapter

Description of change

New Bidder Adapter for SARA

  • test parameters for validating bids
{
  bidder: 'sara',
  params: {
    uid: 5
  }
}

@SARA-HB SARA-HB closed this Feb 21, 2018
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaiminpanchal27
Copy link
Collaborator

To merge i will need Docs PR. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

@bretg
Copy link
Collaborator

bretg commented Mar 21, 2018

@jaiminpanchal27 - docs PR is prebid/prebid.github.io#628

@jaiminpanchal27
Copy link
Collaborator

@SARA-HB Any update ?

@SARA-HB
Copy link
Contributor Author

SARA-HB commented Mar 29, 2018

@jaiminpanchal27 Please check the test ids again, we setup a campaign to return bids.
As for the docs, they were submitted in prebid/prebid.github.io#628

@jaiminpanchal27
Copy link
Collaborator

@SARA-HB Not returning bids again. I tried testing using this page https://github.com/prebid/Prebid.js/blob/master/integrationExamples/gpt/hello_world.html

Tried both uid 5 and 6

@jaiminpanchal27
Copy link
Collaborator

@SARA-HB Any update ?

@SARA-HB
Copy link
Contributor Author

SARA-HB commented Apr 13, 2018

Hey @jaiminpanchal27, it seems that in your example HTML you're calling only appnexus for bids. The bids section doesn't contain anything about 'sara'. Could you please check?

@jaiminpanchal27
Copy link
Collaborator

@SARA-HB hello_world is template we use to test all bidders. We update adUnits with the test params. It works now. Thanks

@jaiminpanchal27 jaiminpanchal27 merged commit f5900ff into prebid:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants