Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update position default value #2214

Merged

Conversation

moonshells
Copy link
Contributor

Type of change

  • Bugfix

Description of change

Prebid.js should send either 'atf' or 'btf' or 'unknown' to ad engine so DPF will receive proper ad position info

@snapwich snapwich self-requested a review March 2, 2018 23:04
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 95fe0a5 into prebid:master Mar 2, 2018
mizmaar3 added a commit to widespace-os/Prebid.js that referenced this pull request Mar 8, 2018
* master: (27 commits)
  Increment pre version
  Prebid 1.5.0 Release
  Fix cross-platform test failures (prebid#2228)
  Fix uncahced video bids from multi-response array triggering callback early (prebid#2219)
  Add vuble adapter (prebid#2201)
  Update Vidazoo domain (prebid#2223)
  InSkin Bid Adapter: remove referrer field from request body (prebid#2217)
  Gamma Support UserSync Endpoint (prebid#2216)
  Feature/stale bot (prebid#2192)
  33Across Bid Adapter: updated user sync endpoint (prebid#2193)
  Adding PR_REVIEW guideline (prebid#2159)
  Add FairTrade Bid Adapter (prebid#2147)
  Add banner support to Beachfront adapter (prebid#2117)
  Smartyads Adapter 1.x (prebid#2080)
  Audience Network: allow native bids for non-IAB sizes (prebid#2203)
  Update position default value in rubicon (prebid#2214)
  Auctionmanager spec refactor pr (prebid#2155)
  fix mediaType being overwritten by undefined in rubicon bid adapter (prebid#2209)
  Fix lint error (prebid#2208)
  VAST support in adform adapter (prebid#2173)
  ...
@moonshells moonshells deleted the update_position_default_value branch March 20, 2018 19:07
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants