Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add billing url (burl) support #2246

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Add billing url (burl) support #2246

merged 1 commit into from
Mar 13, 2018

Conversation

matthewlane
Copy link
Collaborator

Type of change

  • Feature

Description of change

Adds billing url support to prebidServer adapter. In OpenRTB, this field is called burl. Prebid will call this url for S2S bid responses after and if that bid is rendered. This does not include video bid support, which would follow a different rule according to the OpenRTB spec.

@bretg
Copy link
Collaborator

bretg commented Mar 12, 2018

@bretg bretg requested a review from idettman March 13, 2018 00:49
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewlane
Copy link
Collaborator Author

@bretg It might not be in master yet, this is mostly according to the OpenRTB spec. When it's implemented there the docs may also be updated, ccing @dbemiller to check if this is correct

@dbemiller
Copy link
Contributor

That is correct, yes. The auction.md docs link to the OpenRTB spec, which mentions it here: https://www.iab.com/wp-content/uploads/2016/03/OpenRTB-API-Specification-Version-2-5-FINAL.pdf#page=34

It may be worth documenting inside Prebid.js if it's not already, though, because you're not as tightly coupled to OpenRTB as PBS is, and bidObject.burl is creating a feature which other adapters could also use if they wanted.

@mkendall07
Copy link
Member

@bretg it's an optional field for a bidder to supply but Dave's right it's part of the ORTB spec so not sure we need to call it out specifically or not in the docs.

@idettman idettman merged commit 3b26c3a into master Mar 13, 2018
@matthewlane matthewlane deleted the burl branch March 13, 2018 21:51
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Mar 15, 2018
* 'master' of https://github.com/prebid/Prebid.js: (76 commits)
  Updated adUnitCode (prebid#2262)
  vastUrl is set based on nurl for video. (prebid#2249)
  Added ad id to a4g bid (prebid#2250)
  Add billing url (burl) support (prebid#2246)
  Fix: add mediatype in bid response (prebid#2260)
  use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245)
  create RELEASE_SCHEDULE.md (prebid#2255)
  Update Platform.io Adapter (prebid#2230)
  Update Lifestreet adapter to 1.0 (prebid#2197)
  PBS adapter not sending app or device (prebid#2206)
  Fix prebid#2229 - Edge cookie string form (prebid#2236)
  Add Invibes Adapter (prebid#2202)
  Increment pre version
  Prebid 1.5.0 Release
  Fix cross-platform test failures (prebid#2228)
  Fix uncahced video bids from multi-response array triggering callback early (prebid#2219)
  Add vuble adapter (prebid#2201)
  Update Vidazoo domain (prebid#2223)
  InSkin Bid Adapter: remove referrer field from request body (prebid#2217)
  Gamma Support UserSync Endpoint (prebid#2216)
  ...
mizmaar3 added a commit to widespace-os/Prebid.js that referenced this pull request Mar 19, 2018
* master:
  Audience Network: Add 'pbv' and 'cb' query params (prebid#2252)
  Add e-planning analytics adapter (prebid#2211)
  Add vastUrl for Gamma Adapter Video (prebid#2261)
  update params for test bid (prebid#2267)
  Updated adUnitCode (prebid#2262)
  vastUrl is set based on nurl for video. (prebid#2249)
  Added ad id to a4g bid (prebid#2250)
  Add billing url (burl) support (prebid#2246)
  Fix: add mediatype in bid response (prebid#2260)
  use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245)
  create RELEASE_SCHEDULE.md (prebid#2255)
  Update Platform.io Adapter (prebid#2230)
  Update Lifestreet adapter to 1.0 (prebid#2197)
  PBS adapter not sending app or device (prebid#2206)
  Fix prebid#2229 - Edge cookie string form (prebid#2236)
  Add Invibes Adapter (prebid#2202)
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants