Fixes #2291 - user cust_params data lost with url option for dfpAdServerVideo module #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
changed the title
jaiminpanchal27
approved these changes
Mar 30, 2018
jaiminpanchal27
requested review from
harpere and
mike-chowla
and removed request for
harpere
jaiminpanchal27
added
LGTM
needs 2nd review
mkendall07
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When user was attempting to pass their own
cust_paramsdata in a dfp video URL for thedfpAdServerVideomodule, the module was dropping the original data and only setting the module's own data.This fix preserves the original data and merges it with the module's data to make one unified encoded string for the
cust_paramsfield.Note - the
paramsroute for the module was handling the merge of the user'scust_paramsand the module's data fine; this issue only applied to theurlroute for the module.Other information
fix for issue #2291