Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart: User sync #2310

Merged
merged 4 commits into from
Apr 9, 2018
Merged

Smart: User sync #2310

merged 4 commits into from
Apr 9, 2018

Conversation

ytyukhnin
Copy link
Contributor

@ytyukhnin ytyukhnin commented Mar 23, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This PR includes an implementation of the user synchronization feature for Smart's Prebid adapter. Smart is only supporting an IFRAME user synchronization.

Please use the following test parameters:

          {
            code: 'div-gpt-ad-1460505748561-0',
            sizes: [[300, 250]],  // a display size
            bids: [{
              bidder: "smart",
              params: {
                domain: 'http://ww251.smartadserver.com',
                siteId: 207435,
                pageId: 896536,
                formatId: 62913
              }
            }]
          }

and configuration:

          pbjs.setConfig({
            userSync: {
                iframeEnabled: true
          }});

As a result Smart's adapter should call the following user synchronization mechanism: csync.smartadserver.com/rtb/csync/CookieSyncV.html

This PR also includes a minor change in error logging.

@Spacedragoon
Copy link
Contributor

Hello @idettman,
any news ?

@idettman idettman merged commit 275e67d into prebid:master Apr 9, 2018
@idettman idettman added LGTM and removed needs review labels Apr 9, 2018
@ytyukhnin ytyukhnin deleted the user-sync branch May 14, 2018 09:12
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* getUserSyncs function implementation

* bugfix and unit-tests

* unit-test to test that interpretResponse don't throw

* lint issue fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants