Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix legacy sizes in prebidserverAdapter #2364

Merged

Conversation

snapwich
Copy link
Collaborator

@snapwich snapwich commented Apr 5, 2018

Type of change

  • Bugfix

Description of change

Our QA noticed errors with prebidServer legacy endpoint in the new 1.7.0 release related to #2332, it appears a spot was missed that was expecting the old transformed sizes. This fixes that bug.

@robertrmartinez
Copy link
Collaborator

It was in the request builder for openRTB2 actually, but yes, this fixes it.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaiminpanchal27 jaiminpanchal27 merged commit 2ed32db into prebid:master Apr 13, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@robertrmartinez robertrmartinez deleted the fix-size-prebidserver branch July 5, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants