Legacy Sonobi Adapter - Added debugging and analytics params to bid request. #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapwich
requested changes
Apr 30, 2018
| @@ -287,9 +286,14 @@ describe('Sonobi adapter tests', () => { | |||
|
|
|||
| it('should attempt to call bidder for: ' + adUnitName, () => { | |||
| adapter.callBids(adUnit); | |||
| expect(stubLoadScript.args[0][0].indexOf('vp=tablet')).to.not.equal(-1); | |||
There was a problem hiding this comment.
This will fail in browserstack (as I've learned after merging the 1.0 version of this) since it tests on various devices. You need to do a fix similar to something like I did here for the master branch: 3767129
|
@snapwich ah I didn't realize. I committed the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
No documentation change necessary.
Added extra parameters for debugging and analytics purposes.
Fixed issue where sonobi adapter might make a bid request with an empty key_maker object.