Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to bridgewellBidAdapter #2480

Merged
merged 9 commits into from
May 3, 2018
Merged

add feature to bridgewellBidAdapter #2480

merged 9 commits into from
May 3, 2018

Conversation

wuleo
Copy link
Contributor

@wuleo wuleo commented May 2, 2018

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

To support mediaType native

@jsnellbaker jsnellbaker self-assigned this May 2, 2018
@jsnellbaker jsnellbaker self-requested a review May 2, 2018 17:12
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wuleo Thanks for putting these changes together. The code looks good and the test param information you provided was working fine for me.

My only request would be to submit a separate PR in the docs repo and add the following variable to your bidders page in the bidders directory so that you're noted as supporting Native.

media_types: native

If you create this docs PR, we should be good to merge here.

@wuleo
Copy link
Contributor Author

wuleo commented May 3, 2018

Hi @jsnellbaker, very appreciate for your review.
Here is the docs PR.

@bretg
Copy link
Collaborator

bretg commented May 3, 2018

Docs PR confirmed. Merging.

@bretg bretg merged commit bea6ab0 into prebid:master May 3, 2018
@wuleo
Copy link
Contributor Author

wuleo commented May 4, 2018

Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants