Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only send OpenX BO beacon once per page load #2484

Merged
merged 1 commit into from
May 3, 2018
Merged

Only send OpenX BO beacon once per page load #2484

merged 1 commit into from
May 3, 2018

Conversation

haohany
Copy link
Contributor

@haohany haohany commented May 2, 2018

Type of change

  • Bugfix

Description of change

Currently the beacon is sent for each ad unit, which is unnecessary and eats up pixel quota.

@jsnellbaker jsnellbaker self-assigned this May 3, 2018
@jsnellbaker jsnellbaker self-requested a review May 3, 2018 12:45
jsnellbaker
jsnellbaker approved these changes May 3, 2018
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit e247211 into prebid:master May 3, 2018
@haohany haohany deleted the fix-beacon branch May 3, 2018 17:25
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@haohany @dluxemburg
Only send OpenX BO beacon once per page load (prebid#2484)
79025b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haohany @jsnellbaker