Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix - mantisBidAdapter.js #2509

Merged
merged 3 commits into from
Jun 1, 2018
Merged

Conversation

parisholley
Copy link
Contributor

wasn't reading the right value out of the response

@parisholley
Copy link
Contributor Author

@dmitriyshashkin will fix the issue, also pushing a backend change that can work around

Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super simple change - but makes me think there's a test needed to catch this scenario.

@harpere harpere self-assigned this May 11, 2018
@harpere
Copy link
Collaborator

harpere commented May 21, 2018

@parisholley can we add a test around this change?

@parisholley
Copy link
Contributor Author

@harpere done

@dmitriyshashkin
Copy link
Contributor

@harpere sorry to bother you but we'd appreciate if you could review this before the next release. We're missing all revenue we used to get from this bidder

@jaiminpanchal27 jaiminpanchal27 merged commit 2e045a1 into prebid:master Jun 1, 2018
Pupis pushed a commit to adform/Prebid.js that referenced this pull request Jun 7, 2018
* Update mantisBidAdapter.js

* tests for uuid storage

* typo
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Update mantisBidAdapter.js

* tests for uuid storage

* typo
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* Update mantisBidAdapter.js

* tests for uuid storage

* typo
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* Update mantisBidAdapter.js

* tests for uuid storage

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants