-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDPR parameters in ad request #2522
Merged
Merged
Changes from 58 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
632c8c1
add stickyadsTV bidder adapter
a91ac2d
init unit test file
9e2d70e
ad some unit tests
9c92c3e
fix unit test on ad format with parameters
7ed68e9
add some unit tests
88a45ac
add unit tests on getBid method
7d6bf3c
add some test cases in unit tests
affdd67
minor fix on component id tag.
654a473
remove adapters-sticky.json test file
3b0760e
Merge remote-tracking branch 'Prebid/master'
8c0f143
use top most accessible window instead of window.top
fd877dc
Pass in the bid request in the createBid call.
09f7348
use top most accessible window instead of window.top
28a36a6
Merge remote-tracking branch 'Prebid/master'
90264e8
add unit tests
29453af
update unit tests
b664ee1
fix unit test.
57c31a1
fix CI build
2915576
Merge remote-tracking branch 'Prebid/master'
c5c41be
Merge remote-tracking branch 'Prebid/master'
475eee3
add alias freewheel-ssp
71bfaa1
Merge remote-tracking branch 'Prebid/master'
410ee00
update unit tests on bidderCode value
8f7c947
Merge branch 'master' into master
1d7be59
Merge remote-tracking branch 'Prebid/master'
b09dfdd
fix component id values and add unit tests
d5e6d79
Merge remote-tracking branch 'Prebid/master'
d52df6f
allws to use any outstream format.
9ad2b7f
fix ASLoader on futur outstream format versions
427b45c
minor: fix code format.
c65c62d
update unit tests
23639ff
minor fix code format
8c26777
Merge remote-tracking branch 'Prebid/master'
7b2ff67
minor: add missing new line at eof
cea7ebd
Merge remote-tracking branch 'Prebid/master'
025f361
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky ecaff5e
replace StickyAdsTVAdapter by freewheel ssp bd adapter (for prebid 1.0)
guillaume-sticky 584d8fd
remove old stickyadstv unittest spec.
guillaume-sticky 545876d
fix server response parsing if sent as object with 'body' field
guillaume-sticky 4735b30
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky c6db605
use the vastXml field for video mediatype
guillaume-sticky 6740fbf
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky 8aae6c6
add user sync pixel in freewheel ssp adapter
guillaume-sticky 6e4d9df
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky fc3e217
remove all console log calls (replaced using util helper)
guillaume-sticky 8d6360b
remove useless bidderCode (automatically added by the bidderFactory)
guillaume-sticky 4ccb39d
Return the SYNC pixel to be added in the page by Prebid.js
guillaume-sticky 57f7c27
remove instance level properties to enable concurrent bids with the s…
guillaume-sticky efee22b
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky 91029d9
fix the request apss through and corresponding unit tests
guillaume-sticky cf55f76
fix 'freeheelssp' typo
guillaume-sticky 10ce504
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky 2af4bad
Merge commit '65c76ef80f68eb41962b98d388dde3259e3c1203'
guillaume-sticky 778c414
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky ebd8e94
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky 113ad29
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky f62aab2
add vast parameters feature and GDPR params in VAST request
guillaume-sticky 0717715
fix lint issues
guillaume-sticky b332946
Merge remote-tracking branch 'Prebid/master'
guillaume-sticky d7f57f4
add gdpr parameter support on freewheelSSPBidAdapter
guillaume-sticky 1ad8abd
use bidderrequest to read gdpr parameters and update unit tests
guillaume-sticky 447785f
fix lint errors
guillaume-sticky 37d95fc
fix lint errors
guillaume-sticky 0238d92
fix typo and bidderRequest reference.
guillaume-sticky 2a18f58
fix bidderRequest reference.
guillaume-sticky de1de4b
add missing declaration for 'key' variable
guillaume-sticky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -223,6 +223,20 @@ export const spec = { | |
componentId: getComponentId(currentBidRequest.params.format) | ||
}; | ||
|
||
if (typeof currentBidRequest.params.gdpr !== 'undefined') { | ||
requestParams._fw_gdpr = currentBidRequest.params.gdpr; | ||
requestParams._fw_gdpr_consent = currentBidRequest.params.gdpr_consent; | ||
} | ||
|
||
var vastParams = currentBidRequest.params.vastUrlParams; | ||
if (typeof vastParams === 'object') { | ||
for (kye in vastParams) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems to be a small typo here; believe it should be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done, thx |
||
if (vastParams.hasOwnProperty(key)) { | ||
requestParams[key] = vastParams[key]; | ||
} | ||
} | ||
} | ||
|
||
var location = utils.getTopWindowUrl(); | ||
if (isValidUrl(location)) { | ||
requestParams.loc = location; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wasn't done properly.
buildRequests(bidRequests, bidderRequest)
has a secondbidderRequest
argument where you'll find thegdpr
params. please see the doc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, more specifically, I believe
gdpr_consent
could exist whilegdpr
is undefined. So checkinggdpr !== 'undefined'
is not a good way to do this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, I'll have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes have been made, thx again.